-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature Request : Add synchronous refreshing methods to saltutil #20590
Comments
This is an issue that does tend to bite people. I think that one approach here might be to make this pseduo-syncrhronous. Instead of blocking the entire minion during a refresh (which is why it's async to begin with), we could setup a poller inside the refresh call that spins until the refresh is complete before returning. We may need to add some singaling to the loader to facilitate this. It's going to require some further discussion and planning but I do agree this is an issue that needs to be resolved. |
I tried to hack my way around that but I had difficulties to make the minion event listening working. I started from the http://docs.saltstack.com/en/latest/topics/event/index.html doc.
frima_saltutil.py
|
It looks like we will be slating this feature for 2015.5, due out in mid-May. |
I link #10304 for the event system exception |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue. |
I really wish synchronous sync will be implemented. I struggling with async races with Salt. |
@Ch3LL any chance to ressurect this request? Having a synchronous option to these modules will open many great possibilities and remove many race conditions like "I did pillars_refresh - can I already start things or they're not refreshed yet?" And so on |
KInda related: #50105 |
Thank you for updating this issue. It is no longer marked as stale. |
as you pointed out in that issue this functionality has been added to refreshing modules and pillar, but would be nice to add it across refreshing all different kinds of modules. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue. |
not stale |
Thank you for updating this issue. It is no longer marked as stale. |
Is it possible to add a sync method/parameter for
saltutil:refresh_pillar
,saltutil:refresh_grains
and all others "refresh_xxx"? Currently the documentation doesn't mention the fact that they are async methods. That create us several mysterious bugs.salt/saltutil.py
We were having a few sls that modified pillars, refreshed them and worked on the "updated" values inside modules :
Do you know a workaround that we could use to obtain real updated values?
The text was updated successfully, but these errors were encountered: