Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: filesystem label support for blockdev.formatted #33857

Open
Talkless opened this issue Jun 8, 2016 · 11 comments
Open

Feature request: filesystem label support for blockdev.formatted #33857

Talkless opened this issue Jun 8, 2016 · 11 comments
Labels
Execution-Module Feature new functionality including changes to functionality and code refactors, etc. Platform Relates to OS, containers, platform-based utilities like FS, system based apps
Milestone

Comments

@Talkless
Copy link
Contributor

Talkless commented Jun 8, 2016

Description of Issue/Question

mkfs.ext4 and mkfs.xfs has -L option to set human readable file system label. Though blockdev.formatted accepts kwargs, blockdev.format execution module does not currently have ability to set label.

@Ch3LL
Copy link
Contributor

Ch3LL commented Jun 9, 2016

@Talkless I think this is a sound idea to add this feature. Thanks

@Ch3LL Ch3LL added Feature new functionality including changes to functionality and code refactors, etc. Platform Relates to OS, containers, platform-based utilities like FS, system based apps Execution-Module labels Jun 9, 2016
@Ch3LL Ch3LL added this to the Approved milestone Jun 9, 2016
@shallot
Copy link

shallot commented Mar 7, 2017

I seem to have run across this issue - I'm trying to get some file systems formatted with specific labels, but blockdev.formatted provides no apparent option to specify a label that would in turn be passed down to the mkfs function.

@dhs-rec
Copy link
Contributor

dhs-rec commented Apr 6, 2018

In addition to this, it would also be great to support passing arbitrary options to the various mkfs tools. For example, I currently need to use a cmd.run to format an XFS filesystem because neither -L nor -f are supported by blockdev.formatted:

format_device:
  cmd.run:
    - name: mkfs.xfs -f -LDOCKER /dev/{{ storage_dev }}
    - unless: blkid -p -n xfs /dev/{{ storage_dev }}|grep xfs
@mruepp
Copy link

mruepp commented Jun 7, 2018

Is there still no way to pass arguments to blockdev.formatted?

@Ch3LL
Copy link
Contributor

Ch3LL commented Jun 11, 2018

No but we are always willing to accept PRs :)

@stale
Copy link

stale bot commented Sep 24, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Sep 24, 2019
@Talkless
Copy link
Contributor Author

Ping.

@stale
Copy link

stale bot commented Sep 25, 2019

Thank you for updating this issue. It is no longer marked as stale.

@stale stale bot removed the stale label Sep 25, 2019
@stale
Copy link

stale bot commented Jan 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Jan 7, 2020
@dhs-rec
Copy link
Contributor

dhs-rec commented Jan 8, 2020

And another ping.

@stale
Copy link

stale bot commented Jan 8, 2020

Thank you for updating this issue. It is no longer marked as stale.

@stale stale bot removed the stale label Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Execution-Module Feature new functionality including changes to functionality and code refactors, etc. Platform Relates to OS, containers, platform-based utilities like FS, system based apps
5 participants