Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: salt-bootstrap use master version for minion version if master is configured #42478

Open
aikar opened this issue Jul 21, 2017 · 8 comments
Labels
Core relates to code central or existential to Salt Feature new functionality including changes to functionality and code refactors, etc.
Milestone

Comments

@aikar
Copy link

aikar commented Jul 21, 2017

Description of Issue/Question

let me preface I understand the salt-cloud is not part of the salt-master, and can be used without a master.

During minion provisioning, if a master is configured to be set for this minion, and a version is not already being supplied to the salt-bootstrap command,
then I suggest that salt-bootstrap file reaches out to the master to determine it's version, and automatically use that version.

Before discovering how to define minion version using script/script_args for the salt-cloud provider, minions being installed as latest before we had the chance to update the master has caused numerous problems, and I am sure it has hit many more than us.

If the salt-bootstrap has version supplied, then obviously this logic should not engage. It should occur when no version has been supplied, and try to synchronize with master if a master exists, else use latest.

@gtmanfred gtmanfred added Core relates to code central or existential to Salt Feature new functionality including changes to functionality and code refactors, etc. labels Jul 21, 2017
@gtmanfred gtmanfred added this to the Approved milestone Jul 21, 2017
@gtmanfred
Copy link
Contributor

That is a great idea, I am marking it as a feature request.

If you have time, would you mind submitting a PR to the develop branch to implement this feature (if you do, please also include a note in the release documentation for the Oxygen release)

Thanks,
Daniel

@aikar
Copy link
Author

aikar commented Jul 22, 2017

Sorry I do not know python, nor time to learn it, to do this myself.

@stale
Copy link

stale bot commented Nov 16, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Nov 16, 2018
@gtmanfred
Copy link
Contributor

this would take minimal effort to add and would fit the guidelines for salt-cloud, the default version that should be used for bootstrapping is the same version of salt that salt-cloud is.

@saltstack/team-triage

@stale
Copy link

stale bot commented Nov 17, 2018

Thank you for updating this issue. It is no longer marked as stale.

@stale stale bot removed the stale label Nov 17, 2018
@stale
Copy link

stale bot commented Jan 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Jan 9, 2020
@aikar
Copy link
Author

aikar commented Jan 9, 2020

Unless this has already been done, this is absolutely something that should remain open and be done.

@stale
Copy link

stale bot commented Jan 9, 2020

Thank you for updating this issue. It is no longer marked as stale.

@stale stale bot removed the stale label Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core relates to code central or existential to Salt Feature new functionality including changes to functionality and code refactors, etc.
2 participants