-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature Request] supervisord.running state should check for retcode #50566
Comments
@Oloremo Thanks for the report. we should definitely account for the retcode is supervisord is going to start returning them in future versions. Marking this as a feature request for a future feature addition. Thanks! |
@garethgreenaway We are running Salt-2019.2.0 and supervisor 4.0.4. Since supervisor returns non-zero exit codes for supervisorctl status, it breaks salt states that depend on return of a 0 code for successful execution. Maybe as a short-term fix, the return code can be discarded in salt's |
we're using this local patch to workaround this:
But a proper fix would be appreciated. |
@Oloremo A smaller patch can be to pass |
Well, I want to catch errors. :-) It's not about avoiding the error states it's about to handle it properly. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue. |
Supervisord 4.x released long time ago with the support of proper exit codes yet for Salt it's still always 0. |
Thank you for updating this issue. It is no longer marked as stale. |
Description of Issue/Question
Look like supervisord.running state is not checking the return codes of the supervisordctl.
It's probably ok since the current (3.x) version of the supervisord is always returning the 0 exit code. But the version from master (future 4.x) already has Supervisor/supervisor#668 merged which adds the correct exit codes and we use supervisord with this patch to enforce the exit codes.
Not sure what is the Salt policy for such situations.
Steps to Reproduce Issue
The example above will always be successful and will always try to apply state on each run.
Versions Report
The text was updated successfully, but these errors were encountered: