Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "npm ci" support to npm module & state #51791

Open
ralish opened this issue Feb 24, 2019 · 4 comments
Open

Add "npm ci" support to npm module & state #51791

ralish opened this issue Feb 24, 2019 · 4 comments
Labels
Feature new functionality including changes to functionality and code refactors, etc.
Milestone

Comments

@ralish
Copy link
Contributor

ralish commented Feb 24, 2019

Description of Issue/Question

For installing Node.js modules Salt provides the npm state which provides support for installing packages via a package.json file. Internally this results in Salt calling npm install. Recent versions of npm include the npm ci command which is far better suited to continuous integration and deployment scenarios as it ensures reproducible builds.

Introducing support should be relatively straightforward as the semantics are (near?) identical to npm install. For the npm state I propose adding a boolean option to the bootstrap function which will trigger usage of npm ci (and fail the state if it returns non-zero). In the npm module an equivalent boolean option should be implemented in the install function for the state to use.

I'm happy to take a stab at implementing support when I find some spare time if someone else doesn't beat me to it.

References:

@dwoz dwoz added the Feature new functionality including changes to functionality and code refactors, etc. label Feb 25, 2019
@dwoz dwoz added this to the Approved milestone Feb 25, 2019
@dwoz
Copy link
Contributor

dwoz commented Feb 25, 2019

@ralish Thanks, Looking forward to seeing your PR. :)

@stale
Copy link

stale bot commented Jan 9, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Jan 9, 2020
@ralish
Copy link
Contributor Author

ralish commented Jan 9, 2020

Please keep open. This is an important feature request and one I'd like to work on eventually.

@stale
Copy link

stale bot commented Jan 9, 2020

Thank you for updating this issue. It is no longer marked as stale.

@stale stale bot removed the stale label Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature new functionality including changes to functionality and code refactors, etc.
2 participants