-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
/learning response change #64
Comments
Whats "name"? |
The Username is in the current message that is returned (it shouldn't be needed). Name is location name. |
Hmm. So the purpose of "message" is to relay the Debug message that the server itself into its own log. This is useful to me, as a developer, cause I can use a client to "see" the server Debug messages, since currently the App prints out the data['message']. For practical functionality though - does the client need any of this? It already knows the username and the location and the number of APs. The client doesn't even have to output a 'message', it only does right now because its useful for my debugging purposes. Maybe the client only needs to respond to success (which should probably change to an HTTP status code). |
The client probably doesn't need to see any of this. However I imagine for writing API tests it would easier to return the location name, and user within a more "machine" friendly message. If an incorrect user is returned this could highlight major async bugs that could potentially occur. |
it would be nice to get a json response from learning like the following
{
"message": "blah",
"details": {"name":"blah", "APS": 10, "user":"me!"},
"success": true
}
this would make it easier to read with programs utilizing the find system
The text was updated successfully, but these errors were encountered: