Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A sticky footer could make thing even smoother #14

Open
sheriffderek opened this issue Jul 31, 2019 · 3 comments · May be fixed by #17
Open

A sticky footer could make thing even smoother #14

sheriffderek opened this issue Jul 31, 2019 · 3 comments · May be fixed by #17
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sheriffderek
Copy link

At certain screen sizes - the footer kinda jumps around - and gives it just a little less polished feeling that it could have. (Really great job on these transitions!) https://philipwalton.github.io/solved-by-flexbox/demos/sticky-footer/
@sdras
Copy link
Owner

sdras commented Oct 30, 2019

I hadn't noticed that! Probably just browsing too short of a window. Will fix! PRs also accepted.
@sdras sdras added good first issue Good for newcomers help wanted Extra attention is needed labels Oct 30, 2019
@perpetual-education-personal
Copy link

I'm not sure how the <main> animation conditional works - so, it might need a parent. You could use a custom element like <main-outlet> or something (ensure it's block level) - and then add the flex-grow to that... otherwise, it switches out the whole main element. Just using the browser tools - it would be like this:

Screen_Shot_2019-10-30_at_3_03_07_PM
@sdras
Copy link
Owner

sdras commented Oct 30, 2019

I know how sticky footers work :) if you want to PR, please do. Otherwise I'll handle it.
@cstro cstro linked a pull request Nov 14, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
3 participants
@sheriffderek @sdras @perpetual-education-personal