Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add integration tests to ensure captions behavior #1426

Open
ismena opened this issue Apr 27, 2018 · 0 comments
Open

Add integration tests to ensure captions behavior #1426

ismena opened this issue Apr 27, 2018 · 0 comments
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P4 Nice to have / wishful thinking type: code health A code health issue
Milestone
Backlog

Comments

@ismena
Copy link
Contributor

ismena commented Apr 27, 2018

As accurately noted by @theodab, we've already had two bugs caused by new logic that stops streaming text if captions are disabled.
It's also something that's hard to test in isolation.
We should create integration tests to ensure both regular and internal text use cases work as expected.
@ismena ismena added the type: code health A code health issue label Apr 27, 2018
@shaka-bot shaka-bot added this to the Backlog milestone Apr 27, 2018
@joeyparrish joeyparrish modified the milestones: Backlog, v2.6 May 2, 2018
@vaage vaage modified the milestone: v2.6 Nov 26, 2018
@joeyparrish joeyparrish modified the milestones: v2.6, Backlog Feb 12, 2020
@theodab theodab added component: captions/subtitles The issue involves captions or subtitles priority: P4 Nice to have / wishful thinking labels Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: captions/subtitles The issue involves captions or subtitles priority: P4 Nice to have / wishful thinking type: code health A code health issue
5 participants
@ismena @joeyparrish @shaka-bot @vaage @theodab