Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document useful getters for various events #2657

Closed
joeyparrish opened this issue Jun 16, 2020 · 1 comment · Fixed by #7037
Closed

Document useful getters for various events #2657

joeyparrish opened this issue Jun 16, 2020 · 1 comment · Fixed by #7037
Assignees
Labels
flag: good first issue This might be a relatively easy issue; good for new contributors priority: P3 Useful but not urgent type: docs Improvements or fixes to documentation
Milestone

Comments

@joeyparrish
Copy link
Member

Many events have no extra properties, so we should document clearly for these events which getters or other methods an app may want to use on the event. For example, on adaptation events, an app may want to look at getStats() or getVariantTracks() to see what happened.

@joeyparrish joeyparrish added the type: docs Improvements or fixes to documentation label Jun 16, 2020
@shaka-bot shaka-bot added this to the v3.1 milestone Jun 16, 2020
@joeyparrish joeyparrish added the flag: good first issue This might be a relatively easy issue; good for new contributors label Feb 12, 2021
@ismena ismena self-assigned this Feb 12, 2021
@michellezhuogg michellezhuogg self-assigned this Apr 6, 2021
@ismena
Copy link
Contributor

ismena commented Apr 12, 2021

I'm moving this to the backlog for now as it has lower priority than other 3.1 issues.

It will stay assigned to me, so I have it on my radar, but it won't distract the rest of the team.

If we can squeeze it in, we will, otherwise it'll go out in a later release.

@ismena ismena modified the milestones: v3.1, Backlog Apr 12, 2021
@TheModMaker TheModMaker added the priority: P3 Useful but not urgent label Sep 29, 2021
@avelad avelad self-assigned this Jul 15, 2024
@avelad avelad modified the milestones: Backlog, v4.11 Jul 15, 2024
@avelad avelad closed this as completed in 918d231 Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flag: good first issue This might be a relatively easy issue; good for new contributors priority: P3 Useful but not urgent type: docs Improvements or fixes to documentation
6 participants