Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for ID3 tags in mp4 #3351

Closed
ismena opened this issue Apr 19, 2021 · 3 comments
Closed

Add support for ID3 tags in mp4 #3351

ismena opened this issue Apr 19, 2021 · 3 comments
Assignees
@avelad
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs component: HLS The issue involves Apple's HLS manifest format priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v4.3

Comments

@ismena
Copy link
Contributor

ismena commented Apr 19, 2021

We use mux.js to parse ID3 tags in ts streams.
Mp4 also supports embedding ID3.
We should see if we can use mux.js to parse those or implement the parsing using our mp4 parser.
@ismena ismena added type: enhancement New feature or request component: HLS The issue involves Apple's HLS manifest format component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs labels Apr 19, 2021
@ismena ismena mentioned this issue Apr 19, 2021
Closed
@shaka-bot shaka-bot added this to the Backlog milestone Apr 19, 2021
@avelad
Copy link
Collaborator

avelad commented Apr 23, 2021

Please consider not using mux.js, because this adds an external dependency that might not be desired.
@avelad
Copy link
Collaborator

avelad commented Oct 31, 2022

@joeyparrish already done with ID3 parsing in the Shaka.
@joeyparrish
Copy link
Member

Fixed in PR #4409.
@avelad avelad modified the milestones: Backlog, v4.3 Oct 31, 2022
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Dec 30, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: ads The issue involves the Shaka Player ads API or the use of other ad SDKs component: HLS The issue involves Apple's HLS manifest format priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
4 participants
@ismena @joeyparrish @avelad @shaka-bot