Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacing between text lines when any styling present in the webvtt cue #4958

Closed
Peterdoo opened this issue Feb 2, 2023 · 1 comment · Fixed by #4961
Closed

Spacing between text lines when any styling present in the webvtt cue #4958

Peterdoo opened this issue Feb 2, 2023 · 1 comment · Fixed by #4961
Labels
component: WebVTT The issue involves WebVTT subtitles specifically priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@Peterdoo
Copy link

Peterdoo commented Feb 2, 2023

Have you read the FAQ and checked for duplicate open issues?
YES

What version of Shaka Player are you using?
v4.3.4-uncompiled

Can you reproduce the issue with our latest release version?
YES

Can you reproduce the issue with the latest code from main?

Are you using the demo app or your own custom app?
Demo app shaka-player-demo.appspot.com

If custom app, can you reproduce the issue using our demo app?

What browser and OS are you using?
Chrome Version 109.0.5414.120 (Official Build) (64-bit) on Win11

For embedded devices (smart TVs, etc.), what model and firmware version are you using?

What are the manifest and license server URIs?

What configuration are you using? What is the output of player.getConfiguration()?

Demo app shaka-player-demo.appspot.com

What did you do?

Played a HLS video with the following cue in the webvtt file:
10:00:00.000 --> 10:00:04.000 line:90%,end position:10%,line-left align:start
<u>First line is underlined</u> and left positioned.
<i>Second line is italic</i> and left positioned.

What did you expect to happen?
The vertical line spacing between the two text lines should be the same as when there are no formatting tags present in the cue. There should be no additional transparent space between the text lines when any formatting tags are present.

What actually happened?

As soon as there is a formatting tag present in the cue like <i>, <u>, <b>, <c.lime> or similar, there is an additional line spacing between the text lines. There is a transparent space between the lines.

When there are no formatting tags present in the cue, the text lines are displayed without additional line spacing. The box is contiguous without a transparent space between the lines.

Without tags:
image

When any tag is present in the cue (additional transparent space between the lines);
image

@Peterdoo Peterdoo added the type: bug Something isn't working correctly label Feb 2, 2023
@github-actions github-actions bot added this to the v4.4 milestone Feb 2, 2023
@avelad avelad added priority: P2 Smaller impact or easy workaround component: WebVTT The issue involves WebVTT subtitles specifically labels Feb 3, 2023
@avelad
Copy link
Collaborator

avelad commented Feb 3, 2023

@Peterdoo I created #4961

joeyparrish added a commit that referenced this issue Feb 10, 2023
Fixes #4958

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Joey Parrish <joeyparrish@google.com>
joeyparrish added a commit that referenced this issue Mar 1, 2023
Fixes #4958

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Joey Parrish <joeyparrish@google.com>
joeyparrish added a commit that referenced this issue Mar 1, 2023
Fixes #4958

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Joey Parrish <joeyparrish@google.com>
joeyparrish added a commit that referenced this issue Mar 1, 2023
Fixes #4958

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Joey Parrish <joeyparrish@google.com>
joeyparrish added a commit that referenced this issue Mar 2, 2023
Fixes #4958

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Joey Parrish <joeyparrish@google.com>
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Apr 11, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: WebVTT The issue involves WebVTT subtitles specifically priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
2 participants