fix: Fix race that allows multiple text streams to be loaded #5129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@willdharris can you review the test errors? Thanks! |
avelad
added
type: bug
avelad
previously approved these changes
Apr 10, 2023
avelad
previously approved these changes
Apr 10, 2023
avelad
approved these changes
Apr 11, 2023
joeyparrish
approved these changes
Apr 18, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Apr 26, 2023
When enabling text visibility and selecting a new text language simultaneously, a race condition can occur that allows multiple text streams to be loaded in the same text media state. Tracking a sequence id, updates `loadNewTextStream_` to only create a new text media state with the text stream from the last call to `loadNewTextStream_`. Resolves: #4821 --------- Co-authored-by: Dan Sparacio <daniel.sparacio@cbsinteractive.com> Co-authored-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
joeyparrish
pushed a commit
that referenced
this pull request
Apr 26, 2023
When enabling text visibility and selecting a new text language simultaneously, a race condition can occur that allows multiple text streams to be loaded in the same text media state. Tracking a sequence id, updates `loadNewTextStream_` to only create a new text media state with the text stream from the last call to `loadNewTextStream_`. Resolves: #4821 --------- Co-authored-by: Dan Sparacio <daniel.sparacio@cbsinteractive.com> Co-authored-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
joeyparrish
pushed a commit
that referenced
this pull request
Apr 26, 2023
When enabling text visibility and selecting a new text language simultaneously, a race condition can occur that allows multiple text streams to be loaded in the same text media state. Tracking a sequence id, updates `loadNewTextStream_` to only create a new text media state with the text stream from the last call to `loadNewTextStream_`. Resolves: #4821 --------- Co-authored-by: Dan Sparacio <daniel.sparacio@cbsinteractive.com> Co-authored-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
joeyparrish
pushed a commit
that referenced
this pull request
Apr 26, 2023
When enabling text visibility and selecting a new text language simultaneously, a race condition can occur that allows multiple text streams to be loaded in the same text media state. Tracking a sequence id, updates `loadNewTextStream_` to only create a new text media state with the text stream from the last call to `loadNewTextStream_`. Resolves: #4821 --------- Co-authored-by: Dan Sparacio <daniel.sparacio@cbsinteractive.com> Co-authored-by: Casey Occhialini <1508707+littlespex@users.noreply.github.com>
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabling text visibility and selecting a new text language simultaneously, a race condition can occur that allows multiple text streams to be loaded in the same text media state.
Tracking a sequence id, updates
loadNewTextStream_to only create a new text media state with the text stream from the last call toloadNewTextStream_.Resolves: #4821