fix(ads): Fix ads starting muted behavior #5153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would set the starting volume of an ad to 0 if the main video is muted. This had the problem that, because of how our custom mute/unmute functionality on ads worked, that would lead to the "unmute" button setting the ad to the "last volume" of 0. This changes the ads manager to, instead, set the volume of the ad to the volume of the video, and then call the mute function if the ad is muted. That way, the ad will remember the previous volume of the video, and will be able to unmute properly. Closes shaka-project#5125
theodab
added
type: bug
avelad
approved these changes
Apr 14, 2023
joeyparrish
pushed a commit
that referenced
this pull request
Apr 26, 2023
Previously, we would set the starting volume of an ad to 0 if the main video is muted. This had the problem that, because of how our custom mute/unmute functionality on ads worked, that would lead to the "unmute" button setting the ad to the "last volume" of 0. This changes the ads manager to, instead, set the volume of the ad to the volume of the video, and then call the mute function if the ad is muted. That way, the ad will remember the previous volume of the video, and will be able to unmute properly. Closes #5125
joeyparrish
pushed a commit
that referenced
this pull request
Apr 26, 2023
Previously, we would set the starting volume of an ad to 0 if the main video is muted. This had the problem that, because of how our custom mute/unmute functionality on ads worked, that would lead to the "unmute" button setting the ad to the "last volume" of 0. This changes the ads manager to, instead, set the volume of the ad to the volume of the video, and then call the mute function if the ad is muted. That way, the ad will remember the previous volume of the video, and will be able to unmute properly. Closes #5125
joeyparrish
pushed a commit
that referenced
this pull request
Apr 26, 2023
Previously, we would set the starting volume of an ad to 0 if the main video is muted. This had the problem that, because of how our custom mute/unmute functionality on ads worked, that would lead to the "unmute" button setting the ad to the "last volume" of 0. This changes the ads manager to, instead, set the volume of the ad to the volume of the video, and then call the mute function if the ad is muted. That way, the ad will remember the previous volume of the video, and will be able to unmute properly. Closes #5125
github-actions
bot
added
the
status: archived
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would set the starting volume of an ad to 0 if the main video is muted.
This had the problem that, because of how our custom mute/unmute functionality on ads worked, that would lead to the "unmute" button setting the ad to the "last volume" of 0.
This changes the ads manager to, instead, set the volume of the ad to the volume of the video, and then call the mute function if the ad is muted. That way, the ad will remember the previous volume of the video, and will be able to unmute properly.
Closes #5125