Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebVTT wrong writing-mode in nested cues #4765

Closed
Robloche opened this issue Nov 28, 2022 · 1 comment · Fixed by #5641 or #5807
Closed

WebVTT wrong writing-mode in nested cues #4765

Robloche opened this issue Nov 28, 2022 · 1 comment · Fixed by #5641 or #5807
Labels
component: WebVTT The issue involves WebVTT subtitles specifically priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v4.6

Comments

@Robloche
Copy link
Contributor

Have you read the FAQ and checked for duplicate open issues?
Yes.

What version of Shaka Player are you using?
4.3.0

Can you reproduce the issue with our latest release version?
Yes.

Can you reproduce the issue with the latest code from main?
Yes.

Are you using the demo app or your own custom app?
My own app.

If custom app, can you reproduce the issue using our demo app?
Not tried.

What browser and OS are you using?
Chrome 107.0.5304.107 (Build officiel) (64 bits)
Windows Windows 10 Professionnel 21H2

What did you do?
I played a video with side-car WebVTT subtitles that have vertical-lr writing-mode.

What did you expect to happen?
The subtitles should be written vertically.

What actually happened?
They're displayed horizontally, as if the writing-mode was horizontal-tb.

When I look at the cues just after they're parsed, I see this:
image

The root cue (or whatever you want to call it) has the correct vertical-lr writing-mode, but the nested cue has horizontal-tb writing-mode.
I think all nested cues should have the same writing-mode as their root cue.
@Robloche Robloche added the type: bug Something isn't working correctly label Nov 28, 2022
@github-actions github-actions bot added this to the v4.4 milestone Nov 28, 2022
@avelad avelad added the component: WebVTT The issue involves WebVTT subtitles specifically label Nov 29, 2022
@Robloche
Copy link
Contributor Author

Robloche commented Dec 1, 2022

I've got a fix ready but it requires this PR to be merged first: #4767
@avelad avelad added the priority: P2 Smaller impact or easy workaround label Jan 26, 2023
@avelad avelad modified the milestones: v4.4, v4.5 Aug 31, 2023
@avelad avelad mentioned this issue Sep 12, 2023
Merged
avelad added a commit that referenced this issue Sep 12, 2023
@avelad
fix(WebVTT): Fix wrong writing-mode in nested cues (#5641)
56a4cea 
Fixes #4765
joeyparrish pushed a commit that referenced this issue Sep 13, 2023
@avelad @joeyparrish
fix(WebVTT): Fix wrong writing-mode in nested cues (#5641)
8a7e32e 
Fixes #4765
joeyparrish pushed a commit that referenced this issue Sep 13, 2023
@avelad @joeyparrish
fix(WebVTT): Fix wrong writing-mode in nested cues (#5641)
ba9a852 
Fixes #4765
@avelad avelad reopened this Sep 15, 2023
@avelad avelad modified the milestones: v4.5, v4.6 Oct 5, 2023
@avelad avelad mentioned this issue Oct 25, 2023
Merged
avelad added a commit that referenced this issue Oct 25, 2023
@avelad
fix(WebVTT): Fix wrong writing-mode in nested cues (#5807)
ea7d83e 
Fixes #4765
Robloche pushed a commit to Robloche/shaka-player that referenced this issue Nov 30, 2023
@avelad
fix(WebVTT): Fix wrong writing-mode in nested cues (shaka-project#5641)
3384a33 
Fixes shaka-project#4765
Robloche pushed a commit to Robloche/shaka-player that referenced this issue Nov 30, 2023
@avelad
fix(WebVTT): Fix wrong writing-mode in nested cues (shaka-project#5807)
d8a5717 
Fixes shaka-project#4765
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 24, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 24, 2023
joeyparrish pushed a commit that referenced this issue Feb 17, 2024
@avelad @joeyparrish
fix(WebVTT): Fix wrong writing-mode in nested cues (#5807)
f0c2c2d 
Fixes #4765

Backported to v4.3.x
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: WebVTT The issue involves WebVTT subtitles specifically priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
3 participants
@avelad @Robloche @shaka-bot