Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shaka-ui: Subtitles vertical alignment #4446

Closed
Warry opened this issue Aug 26, 2022 · 5 comments · Fixed by #5945
Closed

shaka-ui: Subtitles vertical alignment #4446

Warry opened this issue Aug 26, 2022 · 5 comments · Fixed by #5945
Labels
component: WebVTT The issue involves WebVTT subtitles specifically priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone
v4.7

Comments

@Warry
Copy link

Warry commented Aug 26, 2022 •
edited
Loading

Have you read the FAQ and checked for duplicate open issues?
yes

What version of Shaka Player are you using?
4.2.0

Can you reproduce the issue with our latest release version?
yes

Can you reproduce the issue with the latest code from main?
I have not tried.

Are you using the demo app or your own custom app?
custom app

If custom app, can you reproduce the issue using our demo app?
not applicable

What browser and OS are you using?
Mac firefox & chrome all up to date

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
not applicable

What are the manifest and license server URIs?

see below

What configuration are you using? What is the output of player.getConfiguration()?

default configuration using shaka-ui, see player.getConfiguration() here: https://gist.github.com/Warry/7f8ceced39286fcd6410e4607c4d3695

What did you do?

I have created a SSCCE (minimal app) that loads a dash manifest with a video and subtitles, follow the link then play:

https://cdn.githubraw.com/Warry/shaka-bug/main/index.html

source code: https://github.com/Warry/shaka-bug

What did you expect to happen?
subtitles with line:0 or line:0% should be at the top, nor is line:1, but line:1% is working fine.

What actually happened?

subtitles lines are not aligned to the top as they should, either with line:0 or line:0% or line:1.

image
image
image

line:1% does work:
image
@Warry Warry added the type: bug Something isn't working correctly label Aug 26, 2022
@Warry Warry changed the title Subtitles vertical alignment Aug 26, 2022
@github-actions github-actions bot added this to the v4.3 milestone Aug 26, 2022
@avelad avelad added the component: WebVTT The issue involves WebVTT subtitles specifically label Aug 29, 2022
@Warry Warry mentioned this issue Aug 30, 2022
Merged
@avelad avelad modified the milestones: v4.3, v4.4 Nov 11, 2022
@avelad
Copy link
Collaborator

avelad commented Aug 28, 2023

The current implementation only takes into account %, when using numbers there are no positioning. I have tried and 0% is positioned at the top, which is correct. Can you try on the main branch and see if it reproduces the same results? Thanks!
@avelad avelad added the status: waiting on response Waiting on a response from the reporter(s) of the issue label Aug 28, 2023
@Warry
Copy link
Author

Warry commented Aug 28, 2023 •
edited
Loading

I have updated my minimal app with 4.3.9, and 0% seems to be correctly at the top, while line 0 or line 1 are still at the bottom.
@avelad avelad removed the status: waiting on response Waiting on a response from the reporter(s) of the issue label Aug 28, 2023
@avelad avelad modified the milestones: v4.4, v4.5 Aug 31, 2023
@avelad avelad mentioned this issue Sep 11, 2023
Merged
@avelad avelad added the priority: P2 Smaller impact or easy workaround label Sep 11, 2023
@avelad
Copy link
Collaborator

avelad commented Sep 11, 2023

@Warry I'm going to add support to line:0 in #5632
avelad added a commit that referenced this issue Sep 12, 2023
@avelad
fix(WebVTT): Fix support for line:0 vertical alignment (#5632)
eed393f 
Related to #4446
joeyparrish pushed a commit that referenced this issue Sep 13, 2023
@avelad @joeyparrish
fix(WebVTT): Fix support for line:0 vertical alignment (#5632)
14cdc11 
Related to #4446
joeyparrish pushed a commit that referenced this issue Sep 13, 2023
@avelad @joeyparrish
fix(WebVTT): Fix support for line:0 vertical alignment (#5632)
5074de7 
Related to #4446
@avelad avelad modified the milestones: v4.5, v4.6 Oct 5, 2023
@denys-pavlenko-deltatre
Copy link

Hi @avelad Hope you're doing great. Just want to doublecheck. I'm experiencing the issue with vertical alignment in % on Chromecast (CAST SDK CAF Version: 3.0.0111 which has shaka-player 4.3.4 under the hood). So 0% working fine, but then every percent moving the position too much lower which end up 14% being at the very bottom of the screen. Do you have any idea if it's fixable or already in some roadmap? TIA
2023-11-10 09 16 38
2023-11-10 09 16 41
2023-11-10 09 16 44
2023-11-10 09 16 47
2023-11-10 09 16 51
2023-11-10 09 16 56
2023-11-10 09 17 00
@avelad
Copy link
Collaborator

avelad commented Nov 10, 2023

I don’t know about the CAF implementation, maybe @theodab knows
@avelad avelad modified the milestones: v4.6, v5.0 Nov 16, 2023
@avelad avelad mentioned this issue Nov 28, 2023
Merged
Robloche pushed a commit to Robloche/shaka-player that referenced this issue Nov 30, 2023
@avelad
fix(WebVTT): Fix support for line:0 vertical alignment (shaka-project…
85bd807 
…#5632)

Related to shaka-project#4446
avelad added a commit that referenced this issue Dec 4, 2023
@avelad
fix(WebVTT): Fix support for line vertical alignment (#5945)
9f5e461 
Fixes #4446
avelad added a commit that referenced this issue Dec 4, 2023
@avelad
fix(WebVTT): Fix support for line vertical alignment (#5945)
ce3a2f7 
Fixes #4446
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Feb 2, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Feb 2, 2024
joeyparrish pushed a commit that referenced this issue Feb 17, 2024
@avelad @joeyparrish
fix(WebVTT): Fix support for line vertical alignment (#5945)
1a7d4da 
Fixes #4446
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: WebVTT The issue involves WebVTT subtitles specifically priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
4 participants
@Warry @avelad @shaka-bot @denys-pavlenko-deltatre