Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiline colored VTT subtitles displayed on one line #6374

Closed
Robloche opened this issue Mar 28, 2024 · 2 comments · Fixed by #6394
Closed

Multiline colored VTT subtitles displayed on one line #6374

Robloche opened this issue Mar 28, 2024 · 2 comments · Fixed by #6394
Assignees
Labels
component: captions/subtitles The issue involves captions or subtitles component: WebVTT The issue involves WebVTT subtitles specifically priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Milestone

Comments

@Robloche
Copy link
Contributor

Robloche commented Mar 28, 2024

What version of Shaka Player are you using?
v4.7.11-main-27-gb51e6615e-uncompiled

Can you reproduce the issue with our latest release version?
No.

Can you reproduce the issue with the latest code from main?
Yes.

Are you using the demo app or your own custom app?
The demo

If custom app, can you reproduce the issue using our demo app?
N/A

What browser and OS are you using?
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/123.0.0.0 Safari/537.36

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A

What are the manifest and license server URIs?
uri= https://vod.stream.vno.videofutur.fr/15ddedc0-6bc2-433d-9b35-6a78eb36b434/0565544-HORACE_62_HD_BOX-HD-FI.ism/Manifest(format=mpd-time-cmaf,encryption=cenc).mpd
license server= https://apitest-vod.azureedge.net/rest/v1/license/widevine?token=%2FO5MzhB9czOwDCshhWnt%2BnRNS8U3kysD4NLNlqqKpRiElyOtkxaFvw%3D%3D

What did you do?
I play a movie with subtitles, some of them being displayed over two lines.

What did you expect to happen?
In previous version, including 4.7.11, multiline subtitles are correctly displayed, as below:
image

What actually happened?
With the nightly version, subtitles are displayed on one line:
image

If I look at the DOM, I see this in v4.7.11:
image

And this in the nightly version:
image

The <br> tag is missing in the faulty version.

And here's the part of the VTT file that matches:

00:02:45.640 --> 00:02:48.280 align:center line:91%,end
<c.cyan>Voilà Antoine,</c>
<c.cyan>mon frère aîné.</c>

It seems to me that the VTT parser treats these 2 lines as 2 cues instead of 1 with 2 nested cues, and thus misses the insertion of the line break cue.

@joeyparrish joeyparrish added type: bug Something isn't working correctly component: captions/subtitles The issue involves captions or subtitles component: WebVTT The issue involves WebVTT subtitles specifically priority: P2 Smaller impact or easy workaround labels Mar 28, 2024
@shaka-bot shaka-bot added this to the v5.0 milestone Mar 28, 2024
@avelad
Copy link
Collaborator

avelad commented Apr 3, 2024

It seems that the regression was introduced by tXml, I'm looking it now.

@avelad
Copy link
Collaborator

avelad commented Apr 3, 2024

@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jun 3, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jun 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
component: captions/subtitles The issue involves captions or subtitles component: WebVTT The issue involves WebVTT subtitles specifically priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
4 participants