Multiline colored VTT subtitles displayed on one line #6374
Labels
component: captions/subtitles
The issue involves captions or subtitles
component: WebVTT
The issue involves WebVTT subtitles specifically
priority: P2
Smaller impact or easy workaround
status: archived
Archived and locked; will not be updated
type: bug
Something isn't working correctly
Milestone
What version of Shaka Player are you using?
v4.7.11-main-27-gb51e6615e-uncompiled
Can you reproduce the issue with our latest release version?
No.
Can you reproduce the issue with the latest code from
main
?Yes.
Are you using the demo app or your own custom app?
The demo
If custom app, can you reproduce the issue using our demo app?
N/A
What browser and OS are you using?
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/123.0.0.0 Safari/537.36
For embedded devices (smart TVs, etc.), what model and firmware version are you using?
N/A
What are the manifest and license server URIs?
uri=
https://vod.stream.vno.videofutur.fr/15ddedc0-6bc2-433d-9b35-6a78eb36b434/0565544-HORACE_62_HD_BOX-HD-FI.ism/Manifest(format=mpd-time-cmaf,encryption=cenc).mpd
license server=
https://apitest-vod.azureedge.net/rest/v1/license/widevine?token=%2FO5MzhB9czOwDCshhWnt%2BnRNS8U3kysD4NLNlqqKpRiElyOtkxaFvw%3D%3D
What did you do?
I play a movie with subtitles, some of them being displayed over two lines.
What did you expect to happen?
![image](https://cdn.statically.io/img/private-user-images.githubusercontent.com/10497009/317694088-e2552062-6317-49a3-896a-819547740d9a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE0MDU2MTQsIm5iZiI6MTcyMTQwNTMxNCwicGF0aCI6Ii8xMDQ5NzAwOS8zMTc2OTQwODgtZTI1NTIwNjItNjMxNy00OWEzLTg5NmEtODE5NTQ3NzQwZDlhLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE5VDE2MDgzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTAxMDBjOWFiMjI3MGM5Y2E2OGEyNmY4NTAyNGU2MWFjNTQ2NmI4YzQ1ZTk0ZGRlODJmZDM0YmNkZjQ3YzQ0MmYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.vDfzpm53UtEKz2l71hPCkRareG6-LmqikUAVJXY_1bY)
In previous version, including 4.7.11, multiline subtitles are correctly displayed, as below:
What actually happened?
![image](https://cdn.statically.io/img/private-user-images.githubusercontent.com/10497009/317693411-b973ecc6-9290-4b8b-bef7-e5c3ff22e4a4.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE0MDU2MTQsIm5iZiI6MTcyMTQwNTMxNCwicGF0aCI6Ii8xMDQ5NzAwOS8zMTc2OTM0MTEtYjk3M2VjYzYtOTI5MC00YjhiLWJlZjctZTVjM2ZmMjJlNGE0LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE5VDE2MDgzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWY0NmUxY2E4ZmI4MzBjYTM3NTg4NzU1MjQ5NjI2N2Y3MTkxZDAyMzc4MTM1ZWIwMjUyZGI1NGQ1NzY5NDQ3MmMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ug5UJBeZ4qPcgxgCiDc9qFmEYVEwae66eHonosZxwIc)
With the nightly version, subtitles are displayed on one line:
If I look at the DOM, I see this in v4.7.11:
![image](https://cdn.statically.io/img/private-user-images.githubusercontent.com/10497009/317695090-4aa150fa-cae2-4216-8544-821114ecb8fb.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE0MDU2MTQsIm5iZiI6MTcyMTQwNTMxNCwicGF0aCI6Ii8xMDQ5NzAwOS8zMTc2OTUwOTAtNGFhMTUwZmEtY2FlMi00MjE2LTg1NDQtODIxMTE0ZWNiOGZiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE5VDE2MDgzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTJiNzUwYzUwZTUwMTQ1YmQ1OGNlMGVlYzA3NDM3NDM1NmM0NzM2MmZiMmE2ZjczNmQxMDlhN2VjNzI1ZGJkYzkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.2S_z_fCXG70ZJYu6_DurdW8x1TLb6LykdHnlz76R6mU)
And this in the nightly version:
![image](https://cdn.statically.io/img/private-user-images.githubusercontent.com/10497009/317694691-75040a2b-b890-4a4c-98db-17e330870068.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE0MDU2MTQsIm5iZiI6MTcyMTQwNTMxNCwicGF0aCI6Ii8xMDQ5NzAwOS8zMTc2OTQ2OTEtNzUwNDBhMmItYjg5MC00YTRjLTk4ZGItMTdlMzMwODcwMDY4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTklMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzE5VDE2MDgzNFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTA4ZWZmNmMwNmFjYmE1NjI3NjRkYTU5YzNkNmQzZGY2MWFhYzI3NTYwYTQ4M2Y0OTM4N2E4MTY4NGU3NWM5OGEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.RxixljuoBvGgOu-twtglhndiH_IkC6lkoLGV7GBoKdI)
The
<br>
tag is missing in the faulty version.And here's the part of the VTT file that matches:
It seems to me that the VTT parser treats these 2 lines as 2 cues instead of 1 with 2 nested cues, and thus misses the insertion of the line break cue.
The text was updated successfully, but these errors were encountered: