Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add timeout to fullyLoaded in src= #6676

Merged
merged 2 commits into from
May 28, 2024
Merged

fix: Add timeout to fullyLoaded in src= #6676

merged 2 commits into from
May 28, 2024

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented May 27, 2024

Fixes #6664
@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround labels May 27, 2024
@avelad avelad added this to the v4.9 milestone May 27, 2024
@shaka-bot
Copy link
Collaborator

shaka-bot commented May 27, 2024 •
edited
Loading

Incremental code coverage: 87.50%
xilin
xilin reviewed May 28, 2024
View reviewed changes
lib/player.js Outdated Show resolved Hide resolved
@avelad
Merge branch 'main' into src-timeout
f532520 
# Conflicts:
#	externs/shaka/player.js
#	lib/util/player_configuration.js
@avelad avelad merged commit 64e4fd8 into shaka-project:main May 28, 2024
15 checks passed
@avelad avelad deleted the src-timeout branch May 28, 2024 07:36
@shaka-bot shaka-bot mentioned this pull request May 28, 2024
Merged
avelad added a commit that referenced this pull request May 28, 2024
@avelad
fix: Add timeout to fullyLoaded in src= (#6676)
5fa9b4a 
Fixes #6664
@shaka-bot shaka-bot mentioned this pull request May 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
4 participants
@avelad @shaka-bot @xilin @theodab