fix(DASH): Firefox multi-period/multi-codec bug #6691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o support MediaCapabilitiesInfo objects too
avelad
added
type: bug
|
Incremental code coverage: 0.00% |
avelad
approved these changes
May 29, 2024
theodab
approved these changes
May 29, 2024
avelad
pushed a commit
that referenced
this pull request
May 29, 2024
joeyparrish
pushed a commit
that referenced
this pull request
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe a bug was introduced as part of the refactor in this PR #6348 that affects Firefox.
This line here https://github.com/shaka-project/shaka-player/blob/main/lib/util/stream_utils.js#L561 , would clone mediacapabilitiesInfo only if this was a plain
Object. This seems to be the case in Chrome, however, it looks like the Firefox implementation ofMediaCapabilities.decodingInfo()returns a "non-simple"MediaCapabilitiesInfoobject instead - that results in cloneObject retuning null, see screens:FF:
Chrome:
Switching to use shallow clone instead fixes the problem.
Fixes #6690