fix(preload): Copy net filters to preload manager #6709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some assets might rely on networking engine filters (request and response filters) to properly download their assets. However, the preload manager's need to use a fresh networking engine also caused it to not use any filters set on the player already. This changes the process of setting up a preload manager, to make it copy over any filters defined on the player's networking engine. Issue shaka-project#6698
avelad
added
the
priority: P1
avelad
approved these changes
May 30, 2024
|
Incremental code coverage: 91.67% |
joeyparrish
pushed a commit
that referenced
this pull request
May 31, 2024
Some assets might rely on networking engine filters (request and response filters) to properly download their assets. However, the preload manager's need to use a fresh networking engine also caused it to not use any filters set on the player already. This changes the process of setting up a preload manager, to make it copy over any filters defined on the player's networking engine. Fixes #6698
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some assets might rely on networking engine filters (request and response filters) to properly download their assets. However, the preload manager's need to use a fresh networking engine also caused it to not use any filters set on the player already. This changes the process of setting up a preload manager, to make it copy over any filters defined on the player's networking engine.
Fixes #6698