Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial idea for canonical version logic #7227

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

initial idea for canonical version logic #7227

wants to merge 1 commit into from

Conversation

kevinh-hcl
Copy link

Initial quick draft of an idea regarding #7226. This is a first draft, so feel free to give any feedback on improvements or misuse of any of the mechanisms of mkdocs or the theme.
@kevinh-hcl kevinh-hcl mentioned this pull request May 31, 2024
Open
4 tasks
@squidfunk squidfunk linked an issue Jun 1, 2024 that may be closed by this pull request
Version switcher fails to stay on the same page when canonical_version is set in mike #7226
Open
4 tasks
@squidfunk
Copy link
Owner

Thanks for the PR. Could I ask you to simplify the control flow and scope the code added to a check for canonical_version? I'm not sure if this breaks anything, because versioning with mike is so hard to test, so I'd rather opt for an approach where we change behavior based on the presence of this flag without mixing with other code. It's currently too hard to follow with checkPath etc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@kevinh-hcl @squidfunk