Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support cgroup mode #1838

Closed
maximelavocat opened this issue Jan 9, 2024 · 1 comment · May be fixed by #1891
Closed

support cgroup mode #1838

maximelavocat opened this issue Jan 9, 2024 · 1 comment · May be fixed by #1891
Labels
enhancement New feature or request Stale

Comments

@maximelavocat
Copy link

maximelavocat commented Jan 9, 2024 •
edited
Loading

TL;DR

Hi, would it be possible to have cgroup mode supported in the next version of this module?

Terraform Resources

https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/container_cluster#cgroup_mode
https://github.com/hashicorp/terraform-provider-google/blob/HEAD/CHANGELOG.md#510-Oct-9-2023

Detailed design

Additional information

I know this mode was introduced in v5.1 of the provider while the current version of the module (v29) is based on v5.0 on the provider.

Not sure how the development of this module is working, will it be embedded "automatically" in the next version (v30) since it will be based at least on v5.1 of the provider? Or each new feature need to be selected to be in the future version of this module?
@maximelavocat maximelavocat added the enhancement New feature or request label Jan 9, 2024
chicocvenancio added a commit to argyle-engineering/terraform-google-kubernetes-engine that referenced this issue Feb 29, 2024
@chicocvenancio
feat(cluster.tf): add support for setting cgroup mode
2d39d8e 
Fix terraform-google-modules#1838
@chicocvenancio chicocvenancio mentioned this issue Feb 29, 2024
Open
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days
@github-actions github-actions bot added the Stale label Mar 22, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Stale
1 participant
@maximelavocat