Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/mig replacement_method should default to SUBSTITUTE #250

Open
apeabody opened this issue Jun 9, 2022 · 3 comments
Open

modules/mig replacement_method should default to SUBSTITUTE #250

apeabody opened this issue Jun 9, 2022 · 3 comments
Labels
enhancement New feature or request triaged Scoped and ready for work

Comments

@apeabody
Copy link
Contributor

apeabody commented Jun 9, 2022

TL;DR

modules/mig replacement_method should default to SUBSTITUTE

https://cloud.google.com/compute/docs/instance-groups/rolling-out-updates-to-managed-instance-groups#replacement_method

Terraform Resources

No response

Detailed design

No response

Additional information

No response

@apeabody apeabody added the enhancement New feature or request label Jun 9, 2022
@github-actions
Copy link

github-actions bot commented Aug 8, 2022

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Aug 8, 2022
@bharathkkb bharathkkb added triaged Scoped and ready for work and removed Stale labels Aug 10, 2022
@bharathkkb
Copy link
Member

@apeabody is SUBSTITUTE recommended by GCP?

@apeabody
Copy link
Contributor Author

It is per https://cloud.google.com/compute/docs/instance-groups/rolling-out-updates-to-managed-instance-groups#replacement_method:

Valid replacementMethod values are:

SUBSTITUTE (default). Replaces VM instances faster during updates because new VMs are created before old ones are shut down. However, instance names aren't preserved because the names are still in use by the old instances.

RECREATE. Preserves instance names through an update. Compute Engine releases the instance name as the old VM is shut down. Then Compute Engine creates a new instance using that same name. To use this mode, you must set maxSurge to 0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triaged Scoped and ready for work
2 participants