Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post-sleep/suspend issues #902

Open
nvkelso opened this issue Nov 8, 2011 · 7 comments
Open

Post-sleep/suspend issues #902

nvkelso opened this issue Nov 8, 2011 · 7 comments

Comments

@nvkelso
Copy link

nvkelso commented Nov 8, 2011

If I haven't used TileMill in a while, or woken from sleep. I get an error dialog saying "No response from server." with only a close box.

It should be more like Gmail where there is a "Retry" button in addition to the "x" close button.

_Nathaniel

@springmeyer
Copy link
Member

@incanus - slippery slope perhaps, but I wonder about if we could handle this in a custom way for the OSX app. If the app has been backgrounded then this error will be meaningless and should likely be postponed.

@willwhite
Copy link
Contributor

It would be good to just get to the bottom of these crashes (if that's what they are). @nvkelso, anything interesting in your TileMill log files?

Also, what's the idea behind the retry button? The close button should dimiss the alert and allow you to continue working.

@nvkelso
Copy link
Author

nvkelso commented Nov 9, 2011

It's poor UX to say something is broken (the error sounds like everything
is broken! not recoverable! I will loose all my work! shit!) with just a
close box with no action to take to save my files. it's kinda distressing.
just saying.

the error msg text should change to be less threatening or a friendly
"retry the server" added.

that machine is at the studio, I'll check the logs Weds.

@springmeyer
Copy link
Member

Yep, I see this all the time as well, when leaving TileMill and the returning after some time. Sometimes I see an odd (seemingly non-fatal) exception in the logs, sometimes not. I will log the exception here when I see it next. Closing the window (as if it in invalid) always works to continue using tilemill.

@incanus
Copy link
Contributor

incanus commented Nov 9, 2011

I think that anything trying to suspend the UI while in background or sleep (events to which we can easily respond) will adversely affect exports, since it's the same process. Hmm. I will look into maybe suspending the WebView so that it doesn't try to load anything.

@incanus
Copy link
Contributor

incanus commented Nov 9, 2011

Can't really suspend the web view, since we can't handle stuff like unsaved changes & the like. Like @willwhite says, we should probably figure out why this is happening under the hood instead and avoid the need for the alert dialog at all.

@yhahn
Copy link
Contributor

yhahn commented Jan 5, 2012

I've updated the issue title. We won't be implementing a Gmail-style "Retry" any time soon -- it would require some deep study in upstream libraries like Backbone and jQuery to make a generalized, retry on any failed request solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants