Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect code in sft_kerning #34

Open
dkoreshkov opened this issue Mar 28, 2024 · 0 comments
Open

Incorrect code in sft_kerning #34

dkoreshkov opened this issue Mar 28, 2024 · 0 comments

Comments

@dkoreshkov
Copy link

When there is more than 1 subtable the loop will break because it adds to offset more than just the subtable length.
offset += 6;
offset += 8;
offset += length;
According to MS, the header contains "Length of the subtable, in bytes (including this header)"

Futhermore, there should be an is_safe_offset litany before bsearch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
1 participant