Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: SponsorBlock segments still skipped despite set to False #755

Closed
2 tasks done
ccfman2004 opened this issue Jun 27, 2024 · 4 comments
Closed
2 tasks done

[Bug]: SponsorBlock segments still skipped despite set to False #755

ccfman2004 opened this issue Jun 27, 2024 · 4 comments
Labels
not an issue Working as intended

Comments

@ccfman2004
Copy link

I've read the documentation

Operating System

Unraid

Your Bug Report

Describe the bug

TA will still skip sponsor segments even though I have it set to disabled for that channel.

Steps To Reproduce

Have the Global SponsorBlock setting as True.
Set a Channel's SponsorBlock override setting to False.
Sometimes when watching a video with SponsorBlock segments the segments will still get skipped even though the SponsorBlock setting for that channel is set to False.

This bug doesn't always happen.

Expected behavior

When a channel's SponsorBlock override setting is set to False, SponsorBlock segments should not be skipped.

Relevant log output

UCXuqSBlHAE6Xw-yeJA0Tunw: set overwrites {'download_format': '', 'autodelete_days': None, 'index_playlists': '', 'integrate_sponsorblock': ''}
UCXuqSBlHAE6Xw-yeJA0Tunw: get metadata from es

Anything else?

lamusmaser — Today at 5:12 AM
Hmm... I wonder if this is a bug similar to the video retention issue we have open, where a channel specific configuration of false is seen as "No channel override", rather than "Channel override: false".

@bbilly1
Copy link
Member

bbilly1 commented Jul 1, 2024

That works fine for me:
Enable sponsorblock globally, disable with channel overwrite, does not add the timestamps.

That happens at index time, so you'll have to reindex if you change settings like that after the fact and want to have it apply immediatly.

@bbilly1 bbilly1 added the not an issue Working as intended label Jul 1, 2024
@ccfman2004
Copy link
Author

ccfman2004 commented Jul 2, 2024

Reindexing doesn't fix it for me. I thought I had that in my initial post but I guess I forgot to mention that.

@bbilly1
Copy link
Member

bbilly1 commented Jul 2, 2024

Then share the log output of the reindex task. Also share the API output of the given video, e.g. /api/video//. Then from your output above it shows that you have "Unset" the sponsorblock on that channel, not deactivated. That would result into going back to the default. See here: https://docs.tubearchivist.com/channels/#about

@bbilly1
Copy link
Member

bbilly1 commented Jul 12, 2024

assuming this has been solved.

@bbilly1 bbilly1 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
not an issue Working as intended
2 participants