Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong BiquadFilter type #14

Open
ppseprus opened this issue May 8, 2017 · 1 comment
Open

Wrong BiquadFilter type #14

ppseprus opened this issue May 8, 2017 · 1 comment

Comments

@ppseprus
Copy link
Contributor

ppseprus commented May 8, 2017

The default BiquadFitler type is highshelf.
The documentation says "Frequencies higher than the frequency get a boost or an attenuation; frequencies lower than it are unchanged.", but I think a lowpass would be better, considering its description "Standard second-order resonant lowpass filter with 12dB/octave rolloff. Frequencies below the cutoff pass through; frequencies above it are attenuated.".
I might not understand these well enough, but lowpass better.

@mavroudisv
Copy link
Member

During the development phase we tried lots of different filter combinations, and indeed low pass was our first choice.

However, it didn't work as expected and we got better performance using the highshelf. However, if you decide to test it and you get better results let me know, and we can always switch..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants