Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Non-HTML5 audio is not covered #15

Open
ppseprus opened this issue May 8, 2017 · 1 comment
Open

Non-HTML5 audio is not covered #15

ppseprus opened this issue May 8, 2017 · 1 comment

Comments

@ppseprus
Copy link
Contributor

ppseprus commented May 8, 2017

The method document.getElementsByTagName('audio') will only return HTML5 audio, but there could be audio embedded in Flash; there's Javascript audio object and God know what else...
@mavroudisv
Copy link
Member

This is true, and it's a known limitation of the extension. Unfortunately, it seems impossible to handle all kinds of audio sources. However, flash is being phased out, and IIRC we do filter javascript audio objects.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@ppseprus @mavroudisv