Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Represent large integer values in UI #28

Open
Erich-e opened this issue Jul 13, 2018 · 3 comments
Open

Represent large integer values in UI #28

Erich-e opened this issue Jul 13, 2018 · 3 comments
Labels
bug

Comments

@Erich-e
Copy link

Erich-e commented Jul 13, 2018

Large integer values (> 10e17) appear to lose precision in the UI.
I'm currently using the ubercadence/web:2.4.1 image.
For example, this DeviceID is passed to the worker as 321588685835436831 but appears as 321588685835436800
screen shot 2018-07-13 at 2 50 50 pm
@nathanboktae
Copy link
Contributor

Yes, this stems from an unfortunate JavaScript limitation where there is only the number type that is a 32-bit floating point value. Currently the code is explicitly processing all Long types from tchannel structs as numbers, but to fix this as best as possible, values exceeding the precision can be kept as strings.

FYI the export API uses a custom JSON serializer so these numbers will still be numbers in JSON, to be compatible with the CLI, so this may be sufficient for you for the short term until this is fixed.
@Erich-e
Copy link
Author

Erich-e commented Jul 19, 2018

Ok, thanks for the clarification.
@Erich-e Erich-e closed this as completed Jul 19, 2018
@Gurpartap Gurpartap mentioned this issue Apr 12, 2020
Closed
@just-at-uber just-at-uber reopened this Apr 21, 2020
@just-at-uber
Copy link
Contributor

Looks like this issue hasn't been fixed (see #144)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug
3 participants
@nathanboktae @Erich-e @just-at-uber