fix(transition-group): not add class v-move to v-show element #7906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnlctrl
suggested changes
Apr 7, 2018
| @@ -77,6 +77,7 @@ export default { | |||
| for (let i = 0; i < prevChildren.length; i++) { | |||
| const c: VNode = prevChildren[i] | |||
| c.data.transition = transitionData | |||
| c.data.isDisplayNone = c.elm.style.display === 'none' | |||
There was a problem hiding this comment.
Accessing element.style here in a loop will probably cause serious perf issues due to forced layouts. More info: https://developers.google.com/web/fundamentals/performance/rendering/avoid-large-complex-layouts-and-layout-thrashing
It's probably better to just check for empty rects ( { x: 0, y: 0, width: 0, height: 0, top: 0, right: 0, bottom: 0, left: 0 }) below
| @@ -175,7 +176,7 @@ function applyTranslation (c: VNode) { | |||
| const newPos = c.data.newPos | |||
| const dx = oldPos.left - newPos.left | |||
| const dy = oldPos.top - newPos.top | |||
| if (dx || dy) { | |||
| if (!c.data.isDisplayNone && (dx || dy)) { | |||
There was a problem hiding this comment.
Here you can check if oldPos is empty rect by comparing every field to { x: 0, y: 0, width: 0, height: 0, top: 0, right: 0, bottom: 0, left: 0 }.
pengchongfu
force-pushed
the
fix-transition-group-display-none
branch
from
f73b857
to
54586ca
Compare
posva
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
devbranch for v2.x (or to a previous version branch), not themasterbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information:
fix #7879