Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add beforeDeactivated hook #9454

Open
danyadev opened this issue Feb 7, 2019 · 2 comments · May be fixed by #9564
Open

Add beforeDeactivated hook #9454

danyadev opened this issue Feb 7, 2019 · 2 comments · May be fixed by #9564

Comments

@danyadev
Copy link

danyadev commented Feb 7, 2019

What problem does this feature solve?

I use :key and keep-alive tag to display chats. And in order to maintain the position of the scroll when switching between chat rooms, I need to save the scrollTop when the hook is deactivated and put it on the element when the hook is activated. But the deactivated hook is already called when the element has been removed from the DOM, so I needed a new hook - beforeDeactivated.

Seriously, this hook is needed just like the others before* hooks.

What does the proposed API look like?

Here, I think, everything is clear. Simple hook.

@dsseng
Copy link

dsseng commented Feb 24, 2019

I want to do this

@dsseng dsseng linked a pull request Feb 24, 2019 that will close this issue
13 tasks
@danyadev danyadev closed this as completed Apr 5, 2019
@danyadev danyadev reopened this Apr 5, 2019
@danyadev
Copy link
Author

danyadev commented Apr 5, 2019

oops

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants