ABNF uses list extension #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igrigorik
reviewed
Apr 13, 2017
| @@ -701,7 +701,7 @@ | |||
| </dfn> HTTP response header field can be used to communicate a policy | |||
| indicating origin(s) that are allowed to see values of attributes that | |||
| would have been zero due to the cross-origin restrictions. The header's | |||
| value is represented by the following ABNF [[!RFC5234]]:</p> | |||
| value is represented by the following ABNF [[!RFC5234]] (using <a href='https://tools.ietf.org/html/rfc7230#section-7'>List Extension</a>, [[!RFC7230]]):</p> | |||
There was a problem hiding this comment.
I believe we can link directly to 7230 and drop 5234?
There was a problem hiding this comment.
but rfc 7230 only defines an extension to rfc5234. It doesn't contain the ABNF syntax. So I concluded that linking to both was better than one of them.
|
@plehegar any idea why the travis builds are failing? Other then that, LGTM. |
|
we don't have a .travis.yml anymore. I desactivated travis for the time being. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #99
Preview | Diff