Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review request for HTTP Status Code in Resource Timing #757

Closed
1 task done
abinpaul1 opened this issue Jul 13, 2022 · 6 comments
Closed
1 task done

Review request for HTTP Status Code in Resource Timing #757

abinpaul1 opened this issue Jul 13, 2022 · 6 comments
Assignees
Labels
Resolution: satisfied The TAG is satisfied with this design

Comments

@abinpaul1
Copy link

abinpaul1 commented Jul 13, 2022

Wotcher TAG!

I'm requesting a TAG review of HTTP Status Code in Resource Timing.

Adds a field responseStatusCode to PerfomanceResourceTiming which holds an integer corresponding to HTTP status code returned when fetching the resource.

Further details:

  • I have reviewed the TAG's Web Platform Design Principles
  • Relevant time constraints or deadlines: September 1, 2022
  • The group where the work on this specification is currently being done: W3C Web Performance WG
  • Major unresolved issues with or opposition to this specification: None
  • This work is being funded by: Google

You should also know that...

We'd prefer the TAG provide feedback as :

💬 leave review feedback as a comment in this issue and @-notify @abinpaul1 @yoavweiss

@domenic
Copy link
Member

domenic commented Jul 13, 2022

I suggest using responseStatus instead of responseStatusCode to better match Fetch's response.status property name.

@hober
Copy link
Contributor

hober commented Jul 26, 2022

It would be good to get @mikewest & @annevk's eyes on this.

@ylafon
Copy link
Member

ylafon commented Jul 26, 2022

This is the kind of information that developers asked since quite a long time, if security and fetch people think that it is done in a way that doesn't enable security risks, then it looks like a valid addition, but iirc, previous attempts failed in the past.

@mikewest
Copy link

The explainer suggests that "The status code is behind CORS check", which would alleviate my concerns. That's the same check we use for the status and statusText members of Response objects through the Fetch API, and doesn't seem unreasonable to extend to timing APIs.

@annevk
Copy link
Member

annevk commented Jul 28, 2022

Yeah, as long as you don't go beyond the normal same-origin policy and its CORS extension in terms of information exposure it ought to be fine. (I vaguely recall prior attempts wanting to expose it all the time, which would be problematic.)

@maxpassion maxpassion self-assigned this Aug 26, 2022
@torgo torgo added this to the 2022-08-29-week milestone Aug 29, 2022
@maxpassion
Copy link

Hi @abinpaul1 , we had a discussion in today's TAG meeting and are generally happy with this proposal.
Thanks @mikewest @annevk for helping with the review.

@maxpassion maxpassion added Resolution: satisfied The TAG is satisfied with this design and removed Progress: external help requested labels Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Resolution: satisfied The TAG is satisfied with this design
8 participants