Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed to download subtitles from Disney Plus #88

Open
rDamascena opened this issue May 1, 2024 · 5 comments
Open

Failed to download subtitles from Disney Plus #88

rDamascena opened this issue May 1, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@rDamascena
Copy link

What is the solution to the problem below?

python subtitle_downloader.py https://www.disneyplus.com/browse/entity-75c90eca-8969-4edb-ac1a-7165cff2671c

Successfully logged in. Welcome **********
Traceback (most recent call last):
  File "C:\Users\Adriana\Documents\Subtitle-Downloader-main\subtitle_downloader.py", line 151, in <module>
    main()
  File "C:\Users\Adriana\Documents\Subtitle-Downloader-main\subtitle_downloader.py", line 140, in main
    service['class'](args).main()
  File "C:\Users\Adriana\Documents\Subtitle-Downloader-main\services\disneyplus\disneyplus.py", line 361, in main
    self.movie_subtitle()
  File "C:\Users\Adriana\Documents\Subtitle-Downloader-main\services\disneyplus\disneyplus.py", line 45, in movie_subtitle
    title = data['text']['title']['full']['program']['default']['content'].strip(
TypeError: 'NoneType' object is not subscriptable
@frankwu8765
Copy link

我也遇到完全一样的问题!不知道是不是因为disney登录之后,还需要选择相应的用户?而一般用户都设置了自己的PIN码,所以程序没有真正的登录进去!这样的话,是不是用cookie的方式更好一些?

@wayneclub wayneclub added the bug Something isn't working label May 9, 2024
@wayneclub
Copy link
Owner

What is the solution to the problem below?

python subtitle_downloader.py https://www.disneyplus.com/browse/entity-75c90eca-8969-4edb-ac1a-7165cff2671c

Successfully logged in. Welcome **********
Traceback (most recent call last):
  File "C:\Users\Adriana\Documents\Subtitle-Downloader-main\subtitle_downloader.py", line 151, in <module>
    main()
  File "C:\Users\Adriana\Documents\Subtitle-Downloader-main\subtitle_downloader.py", line 140, in main
    service['class'](args).main()
  File "C:\Users\Adriana\Documents\Subtitle-Downloader-main\services\disneyplus\disneyplus.py", line 361, in main
    self.movie_subtitle()
  File "C:\Users\Adriana\Documents\Subtitle-Downloader-main\services\disneyplus\disneyplus.py", line 45, in movie_subtitle
    title = data['text']['title']['full']['program']['default']['content'].strip(
TypeError: 'NoneType' object is not subscriptable

Disney Update new API. Fixed. Please try again

@rDamascena
Copy link
Author

What is the solution to the problem below?

python subtitle_downloader.py https://www.disneyplus.com/browse/entity-75c90eca-8969-4edb-ac1a-7165cff2671c

Successfully logged in. Welcome **********
Traceback (most recent call last):
  File "C:\Users\Adriana\Documents\Subtitle-Downloader-main\subtitle_downloader.py", line 151, in <module>
    main()
  File "C:\Users\Adriana\Documents\Subtitle-Downloader-main\subtitle_downloader.py", line 140, in main
    service['class'](args).main()
  File "C:\Users\Adriana\Documents\Subtitle-Downloader-main\services\disneyplus\disneyplus.py", line 361, in main
    self.movie_subtitle()
  File "C:\Users\Adriana\Documents\Subtitle-Downloader-main\services\disneyplus\disneyplus.py", line 45, in movie_subtitle
    title = data['text']['title']['full']['program']['default']['content'].strip(
TypeError: 'NoneType' object is not subscriptable

Disney Update new API. Fixed. Please try again

I tried and the error persists!

python subtitle_downloader.py "https://www.disneyplus.com/browse/entity-d90a933e-3b20-45a3-9bcf-b07e631a603f" --season 1

Successfully logged in. Welcome *******
Traceback (most recent call last):
  File "C:\Users\Adriana\Documents\Subtitle-Downloader-main\subtitle_downloader.py", line 151, in <module>
    main()
  File "C:\Users\Adriana\Documents\Subtitle-Downloader-main\subtitle_downloader.py", line 140, in main
    service['class'](args).main()
  File "C:\Users\Adriana\Documents\Subtitle-Downloader-main\services\disneyplus\disneyplus.py", line 370, in main
    self.movie_subtitle()
  File "C:\Users\Adriana\Documents\Subtitle-Downloader-main\services\disneyplus\disneyplus.py", line 46, in movie_subtitle
    title = data['text']['title']['full']['program']['default']['content'].strip(
TypeError: 'NoneType' object is not subscriptable
@wayneclub
Copy link
Owner

wayneclub commented May 28, 2024

https://www.disneyplus.com/browse/entity-75c90eca-8969-4edb-ac1a-7165cff2671c

I mean I had updated the project need to redownload and try again.

@achatschnecke
Copy link

achatschnecke commented May 31, 2024

https://www.disneyplus.com/browse/entity-75c90eca-8969-4edb-ac1a-7165cff2671c

I mean I had updated the project need to redownload and try again.

It is working for movies only. If I try to download TV series the json-response seems to be empty.

{'data': {'DmcVideoBundle': {'containers': [], 'extras': {'meta': {'hits': 0, 'offset': 0, 'page_size': 50, 'hasMore': False}, 'videos': []}, 'promoLabels': None, 'related': {'experimentToken': '', 'items': [], 'meta': {'hits': 0, 'offset': 0, 'page_size': 8, 'hasMore': False}}, 'video': None}}}

Edit: The recognition for difference between movies and TV shows needs to be updated. I solved it for me by forcing to use the "series_subtitle"-method at the end of the ./Subtitle-Downloader/services/disneyplus/disneyplus.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
4 participants