Fix custom_header to accept multiple headers using custom_headers #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
👋 Hi @yogeshojha, |
yogeshojha
changed the title
yogeshojha
changed the title
yogeshojha
deleted the
1220-bug-global-variable-custom_header-does-not-parse-correctly
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue raised by @Zeetaz #1220
There was a design problem in passing multiple custom_header from scan engine configuration. Multiple headers were not being parsed according to the tool support.
This PR fixes multiple custom headers issue by introducing new
custom_headersThis will accept multiple headers and will be parsed according to the tool support.
However
custom_headerwill be as it is for now, for backwards compatibility, in the future it will be removed. So recomment usingcustom_headers