Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: observablehq/plot Loading
base: main
Choose a base ref
...
head repository: yurivish/plot Loading
compare: main
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 14 commits
  • 4 files changed
  • 2 contributors

Commits on Jan 30, 2024

  1. prototype support for distinguishing hover & click events via the Cus… 

    …tomEvent detail option
    @yurivish
    yurivish committed Jan 30, 2024
    Configuration menu
    Copy the full SHA
    b9e91cd View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2024

  1. dispatch a subclass of Event with a sticky option

    @yurivish
    yurivish committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    cd5988f View commit details
    Browse the repository at this point in the history

  2. move the StickyEvent definition inside the plot function

    @yurivish
    yurivish committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    3687112 View commit details
    Browse the repository at this point in the history

  3. fix formatting

    @yurivish
    yurivish committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    ca18ec3 View commit details
    Browse the repository at this point in the history

  4. let's see what happens if we move the event back out to the top level… 

    …, but alias the global jsdom EventTarget to the window EventTarget...
    @yurivish
    yurivish committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    73a0e67 View commit details
    Browse the repository at this point in the history

  5. Revert "let's see what happens if we move the event back out to the t… 

    …op level, but alias the global jsdom EventTarget to the window EventTarget..."

This reverts commit 73a0e67.
    @yurivish
    yurivish committed Jan 31, 2024
    Configuration menu
    Copy the full SHA
    411a6ce View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2024

  1. store sticky state in a context field rather than on the figure element

    @yurivish
    yurivish committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    9ce5bc4 View commit details
    Browse the repository at this point in the history

  2. add an interactive test for sticky pointers which displays the clicke… 

    …d value
    @yurivish
    yurivish committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    2ff8a1b View commit details
    Browse the repository at this point in the history

  3. rearrange comment

    @yurivish
    yurivish committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    b53c9e8 View commit details
    Browse the repository at this point in the history

  4. manually generate desired output html for snapshot test

    @yurivish
    yurivish committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    57ed10e View commit details
    Browse the repository at this point in the history

  5. align output formatting with the pointerViewof test

    @yurivish
    yurivish committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    91000aa View commit details
    Browse the repository at this point in the history

  6. remove explicit initialization of context.stickyState 

    Co-authored-by: Philippe Rivière <fil@rezo.net>
    @yurivish @Fil
    yurivish and Fil committed Feb 5, 2024
    Configuration menu
    Copy the full SHA
    138b917 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2024

  1. prettier

    @yurivish
    yurivish committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    615ff94 View commit details
    Browse the repository at this point in the history

  2. add generated snapshot test

    @yurivish
    yurivish committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    02023a9 View commit details
    Browse the repository at this point in the history
Loading