[Gen-art] Genart last call review of draft-ietf-cbor-edn-literals-09
Joel Halpern via Datatracker <noreply@ietf.org> Sat, 25 May 2024 20:56 UTC
Return-Path: <noreply@ietf.org>
X-Original-To: gen-art@ietf.org
Delivered-To: gen-art@ietfa.amsl.com
Received: from ietfa.amsl.com (localhost [IPv6:::1]) by ietfa.amsl.com (Postfix) with ESMTP id ACB52C14F680; Sat, 25 May 2024 13:56:23 -0700 (PDT)
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
From: Joel Halpern via Datatracker <noreply@ietf.org>
To: gen-art@ietf.org
X-Test-IDTracker: no
X-IETF-IDTracker: 12.13.0
Auto-Submitted: auto-generated
Precedence: bulk
Message-ID: <171667058369.51387.11108152099068492128@ietfa.amsl.com>
Date: Sat, 25 May 2024 13:56:23 -0700
Message-ID-Hash: NA27G6AGVPWTTDDOBWEUHLOJQDDEUDMD
X-Message-ID-Hash: NA27G6AGVPWTTDDOBWEUHLOJQDDEUDMD
X-MailFrom: noreply@ietf.org
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-gen-art.ietf.org-0; header-match-gen-art.ietf.org-1; header-match-gen-art.ietf.org-2; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header
CC: cbor@ietf.org, draft-ietf-cbor-edn-literals.all@ietf.org, last-call@ietf.org
X-Mailman-Version: 3.3.9rc4
Reply-To: Joel Halpern <jmh@joelhalpern.com>
Subject: [Gen-art] Genart last call review of draft-ietf-cbor-edn-literals-09
List-Id: "GEN-ART: General Area Review Team" <gen-art.ietf.org>
Archived-At: <https://mailarchive.ietf.org/arch/msg/gen-art/91u4e2ydRvQf-B4UeKra2Lb6jn8>
List-Archive: <https://mailarchive.ietf.org/arch/browse/gen-art>
List-Help: <mailto:gen-art-request@ietf.org?subject=help>
List-Owner: <mailto:gen-art-owner@ietf.org>
List-Post: <mailto:gen-art@ietf.org>
List-Subscribe: <mailto:gen-art-join@ietf.org>
List-Unsubscribe: <mailto:gen-art-leave@ietf.org>
Reviewer: Joel Halpern
Review result: Ready with Nits
I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair. Please treat these comments just
like any other last call comments.
For more information, please see the FAQ at
<https://wiki.ietf.org/en/group/gen/GenArtFAQ>.
Document: draft-ietf-cbor-edn-literals-09
Reviewer: Joel Halpern
Review Date: 2024-05-25
IETF LC End Date: 2024-06-05
IESG Telechat date: Not scheduled for a telechat
Summary: This draft is ready for publication as an Informational RFC.
There is one NIT noted below.
Major issues: N/A
Minor issues: N/A
Nits/editorial comments:
It would be helpful if section 4.2 (IANA Considerations creating the
Encoding Indications registry) said it was recording the assignments made
in RFC 8949 section 8.1, and adding the _i indication. It would also be
helpful if that sentence noted that _i is defined in the ABNF appendix, as
otherwise the reader is left going "what is this and where did it come
from?"
- [Gen-art] Genart last call review of draft-ietf-c… Joel Halpern via Datatracker
- [Gen-art] Re: [Last-Call] Genart last call review… Carsten Bormann