Django problem with downloading file from my computer

Question

I am new to Django and I need some assistance. I want to download the file whose path is in plik.localisation (it has been taken from a loop). The problem is with the path. Could someone help me? What am I doing wrong?

My view.py is:

def download(request, path):
    file_path = os.path.join(settings.MEDIA_ROOT, path)
    if os.path.exists(file_path):
        with open(file_path, 'rb') as fh:
            response = HttpResponse(fh.read(), content_type="application/pdf")
            response['Content-Disposition'] = 'inline; filename=' + os.path.basename(file_path)
            return response
    raise Http404

Urls

    path('download/<str:path>',views.download, name="download"),
] + static(settings.MEDIA_URL, document_root=settings.MEDIA_ROOT)

Html

<div class="com">
       {{plik.localisation}} <a href="{% url 'download/path' %}" class="button">download</a>
</div>

I've tried to change that path but still have problem with it.

Answer 1

There is no path() with the name 'download/path' in your urlpatterns so you will get a 404 HTTP response status when you click that anchor tag.

What you want is:

<div class="com">
    <a href="{% url 'download' plik.localisation %}" class="button">download</a>
</div>

---

Aside:

Do you want to show the file as part of a webpage (considering that you are using header Content-Disposition: inline)? If so, why give the anchor tag a text that says "download"? If it is meant to be downloaded by the client, then this is what the server code should look like:

#•••Rest of code•••
if os.path.exists(file_path):
    return FileResponse(open(file_path, 'rb'), as_attachment=True, filename=os.path.basename(file_path)) #[1]

If the file is meant to be shown as part of a webpage, then the anchor tag’s text shouldn’t be "download". That is misleading. It probably should be "view", "open" or any other variant of the same message since it won’t be downloaded. Then your code would be:

#•••Rest of code•••
if os.path.exists(file_path):
    return FileResponse(open(file_path, 'rb'), filename=os.path.basename(file_path))[2]

---

_{^[1] The Content-Type header is automatically set when it can be guessed from the filename, or the name of open_file so no need for "application/pdf".}

_{^[2] as_attachment is False by default. Content-Disposition: inline will now be the header set.}

Answer 2

This code works def download(request, path): with open(path, 'rb') as fh: if os.path.exists(path): return FileResponse(open(path, 'rb'), as_attachment=True, filename=os.path.basename(path)) raise Http404