Differential D207413

Bug 1845037 - [devtools] Revert DevTools screenshots to use the default downloads directory
ClosedPublic
Actions

Authored by jdescottes on Apr 15 2024, 8:45 AM.

Details

Reviewers

ochameau

Group Reviewers

devtools-reviewers

Commits

rMOZILLACENTRAL9991fc63747c: Bug 1845037 - [devtools] Revert DevTools screenshots to use the default…

Bugzilla Bug ID

1845037

Summary

Revert the DevTools bits from Bug 1072345 to be consistent with the Screenshots feature from Firefox.

Test Plan

https://treeherder.mozilla.org/jobs?repo=try&revision=88971662f67e94223924ff91d85b83ba5ea3c38b

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Build Status

Buildable 649507
Build 748307: arc lint + arc unit

Event Timeline

jdescottes created this revision.Apr 15 2024, 8:45 AM

Herald added a project: secure-revision. · View Herald TranscriptApr 15 2024, 8:45 AM

Harbormaster completed remote builds in B649082: Diff 848667.Apr 15 2024, 8:45 AM

phab-bot published this revision for review.Apr 15 2024, 8:45 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Herald added 1 blocking reviewer(s): devtools-reviewers. · View Herald TranscriptApr 15 2024, 8:45 AM

Code analysis found 985 defects in diff 848667:

985 defects found by source-test-node-devtools-tests

IMPORTANT: Found 985 defects (error level) that must be fixed before landing.

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 848667.

jdescottes edited the test plan for this revision. (Show Details)Apr 15 2024, 9:23 AM

Looks good to me (even if on Linux it doesn't change the behavior).

devtools/client/shared/screenshot.js
332

This revision is now accepted and ready to land.Apr 15 2024, 12:32 PM

review

Harbormaster completed remote builds in B649132: Diff 848730.Apr 15 2024, 12:56 PM

Code analysis found 985 defects in diff 848730:

985 defects found by source-test-node-devtools-tests

IMPORTANT: Found 985 defects (error level) that must be fixed before landing.

If you see a problem in this automated review, please report it here.

You can view these defects in the Diff Detail section of Phabricator diff 848730.

Closed by commit rMOZILLACENTRAL9991fc63747c: Bug 1845037 - [devtools] Revert DevTools screenshots to use the default… (authored by jdescottes). · Explain WhyApr 15 2024, 5:17 PM

This revision was automatically updated to reflect the committed changes.

jdescottes added a commit: rMOZILLACENTRAL9991fc63747c: Bug 1845037 - [devtools] Revert DevTools screenshots to use the default….

Revision Contents
Changeset List

Path

Size

Coverage (All)

Coverage (Touched)

devtools/

client/

shared/

screenshot.js

14 lines

91%

webconsole/

test/

browser/

browser_jsterm_screenshot_command_file.js

14 lines

Diff 848888

View Options

devtools/client/shared/screenshot.js