Closed Bug 1072345 Opened 10 years ago Closed 1 year ago

Screenshot icon saves in Download folder in the OS instead of Images folder

Categories

(DevTools :: General, defect, P3)

Product:
DevTools
Component:
General
Platform:
x86_64
Linux
Type:
defect

Tracking

(firefox112 fixed)

Status:
RESOLVED FIXED
Milestone:
112 Branch
Tracking Flags:
Tracking Status
firefox112 --- fixed

People

(Reporter: pascalc, Assigned: connor.pearson)

References

Details

Attachments

(1 file)

Bug 1072345 - Change devtools screenshot save location. r=#devtools-reviewers
48 bytes, text/x-phabricator-request
Details | Review 
Mozilla/5.0 (X11; Linux x86_64; rv:35.0) Gecko/20100101 Firefox/35.0

1/ Click on screenshot icon

expected:
Screenshot saved in the Images OS folder

actual:
Screenshot saved in the Downloads OS folder


Since Firefox saves the screenshot in the Downloads folder, that means it asks the OS to provide this path, so we should ask for the Images folder instead since we are not downloading anything.
Priority: -- → P3
Product: Firefox → DevTools

Still saves to downloads folder as of Mozilla/5.0 (X11; Linux x86_64; rv:84.0) Gecko/20100101 Firefox/84.0

Severity: normal → S3
Assignee: nobody → connor.pearson
Status: NEW → ASSIGNED

I started working on a patch for this. It changes the behavior of saving to first check the preference devtools.screenshot.download.dir then use a default fallback if it's not set.

For macOS, I tried extending it further to use as the default location the directory the user has configured for the system screenshot app. I'm not too familiar with c++ though, so I have no idea if I took the right approach here. I believe it could also be extended for Windows/Linux but I'm not able to test on those devices.

Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1337c522b219
Change devtools screenshot save location. r=devtools-reviewers,xpcom-reviewers,nchevobbe,mstange,nika

https://hg.mozilla.org/mozilla-central/rev/1337c522b219

Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox112: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 112 Branch
You need to log in before you can comment on or make changes to this bug.