Paths

Table of Contentst

Differential D207654

Bug 1870880 - Add isInstance assertion method to Assert.sys.mjs. r?sasha
ClosedPublic
Actions

Authored by gravyant on Apr 17 2024, 1:20 AM.

Details

Reviewers

Sasha

Group Reviewers

webdriver-reviewers

Commits

rMOZILLACENTRALe6242594ba63: Bug 1870880 - Add isInstance assertion method to Assert.sys.mjs. r=Sasha…

Bugzilla Bug ID

1870880

Test Plan

https://treeherder.mozilla.org/jobs?repo=try&revision=4cce11728c80ded8579a37e7721c028721312b04

Diff Detail

Repository

rMOZILLACENTRAL mozilla-central

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

gravyant created this revision.Apr 17 2024, 1:20 AM

Herald added a project: secure-revision. · View Herald TranscriptApr 17 2024, 1:20 AM

Herald added a reviewer: webdriver-reviewers. · View Herald Transcript

Harbormaster completed remote builds in B650030: Diff 849907.Apr 17 2024, 1:20 AM

phab-bot published this revision for review.Apr 17 2024, 1:20 AM

phab-bot changed the visibility from "Custom Policy" to "Public (No Login Required)".

phab-bot changed the edit policy from "Custom Policy" to "Restricted Project (Project)".

phab-bot removed a project: secure-revision.

Thanks! I think it's close to landing, I just have one comment.
Maybe you could address that, and in the meantime I've pushed the changes to CI

remote/shared/webdriver/Assert.sys.mjs
413	I think we should mention here that the class should have `isInstance` method implemented.

gravyant updated this revision to Diff 850289.Apr 17 2024, 3:22 PM

Harbormaster completed remote builds in B650388: Diff 850289.Apr 17 2024, 3:22 PM

Ok, I added a comment mentioning that constructor should have a static isInstance method.

In D207654#7131071, @gravyant wrote:

Ok, I added a comment mentioning that constructor should have a static isInstance method.

Great! The CI is green, so I'm going to land it now. Thanks!

This revision is now accepted and ready to land.Apr 17 2024, 3:27 PM

Ok, thanks for the help!

Closed by commit rMOZILLACENTRALe6242594ba63: Bug 1870880 - Add isInstance assertion method to Assert.sys.mjs. r=Sasha… (authored by gravyant). · Explain WhyApr 17 2024, 4:53 PM

This revision was automatically updated to reflect the committed changes.

gravyant added a commit: rMOZILLACENTRALe6242594ba63: Bug 1870880 - Add isInstance assertion method to Assert.sys.mjs. r=Sasha….

Revision Contents
Changeset List

Path

Size

remote/

shared/

webdriver/

Assert.sys.mjs

30 lines

test/

xpcshell/

test_Assert.js

14 lines

Diff 850329

View Options

remote/shared/webdriver/Assert.sys.mjs