Closed Bug 1870880 Opened 7 months ago Closed 3 months ago

Add "isInstance" assertion method to Assert.sys.mjs

Categories

(Remote Protocol :: WebDriver BiDi, task, P3)

Product:
Remote Protocol
Component:
WebDriver BiDi
Type:
task

Tracking

(firefox127 fixed)

Status:
RESOLVED FIXED
Milestone:
127 Branch
Tracking Flags:
Tracking Status
firefox127 --- fixed

People

(Reporter: Sasha, Assigned: gravyant, Mentored)

Details

(Whiteboard: [lang=js][webdriver:m11:external] )

Attachments

(2 files)

WIP: Bug 1870880 - Add isInstance assertion method to Assert.sys.mjs
48 bytes, text/x-phabricator-request
Details | Review
Bug 1870880 - Add isInstance assertion method to Assert.sys.mjs. r?sasha
48 bytes, text/x-phabricator-request
Details | Review

Follow-up from review: https://phabricator.services.mozilla.com/D196740#inline-1093389. Might be useful to add isInstance assertion method to Assert.sys.mjs to validate if an asserted argument is an instance of a certain class. It should be used only for classes which have isInstance method implemented, and this method should be used for assertion.

Mentor: aborovova
Priority: -- → P3
Whiteboard: [lang=js]

I'll submit a patch for this bug soon.

Assignee: nobody → gravyant

Hi @Sasha, could you please take a look at the WIP patch I submitted and let me know if I'm taking the right approach and/or what I need to change?

Also, are there specific tests that you would like me to run?

Flags: needinfo?(aborovova)

(In reply to gravyant from comment #3)

Hi @Sasha, could you please take a look at the WIP patch I submitted and let me know if I'm taking the right approach and/or what I need to change?

Also, are there specific tests that you would like me to run?

Hi! Thanks for the patch! I've replied to all your questions in the revision (including the testing).

Flags: needinfo?(aborovova)

Thanks, I revised my patch! Let me know if there are any other changes you'd like!

Flags: needinfo?(aborovova)

(In reply to gravyant from comment #6)

Thanks, I revised my patch! Let me know if there are any other changes you'd like!

Great! I've added a comment

Flags: needinfo?(aborovova)
Pushed by aborovova@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e6242594ba63
Add isInstance assertion method to Assert.sys.mjs. r=Sasha,webdriver-reviewers

Thanks again, :sasha. Are there any JS bugs you recommend I take on next?

Flags: needinfo?(aborovova)

(In reply to gravyant from comment #9)

Thanks again, :sasha. Are there any JS bugs you recommend I take on next?

I can suggest for example this one: https://bugzilla.mozilla.org/show_bug.cgi?id=1860812. Let me know if you have any questions.

Flags: needinfo?(aborovova)

https://hg.mozilla.org/mozilla-central/rev/e6242594ba63

Status: NEW → RESOLVED
Closed: 3 months ago
status-firefox127: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
Whiteboard: [lang=js] → [lang=js][webdriver:m11:external]
You need to log in before you can comment on or make changes to this bug.