Remove the automatic assignment of the preference extensions.formautofill.addresses.capture.requiredFields in tests and force each test to manually set it since using the preference is no longer expected.
Details
Details
- Reviewers
dimi - Group Reviewers
credential-management-reviewers - Commits
- rMOZILLACENTRALc935e2628e3d: Bug 1901247, get the required fields from the address meta data so that it is…
- Bugzilla Bug ID
- 1901247
Diff Detail
Diff Detail
- Repository
- rMOZILLACENTRAL mozilla-central
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
In this patch I left the preference in place as a means to override the list of fields. Some tests need to use a blank list, so either this option should be used or the tests will need to be modified.
Comment Actions
Looks good! thanks!
could you help add a test file browser_address_doorhanger_required_fields.js
and move these two subtests - https://searchfox.org/mozilla-central/rev/a26e972e97fbec860400d80df625193f4c88d64e/browser/extensions/formautofill/test/browser/address/browser_address_doorhanger_display.js#241-305
to the new file? We might also need to update the test to ensure we are using requiredFields from the address metadata.