Closed Bug 1634042 Opened 4 years ago Closed 4 years ago

Lazify the page action menu

Categories

(Firefox :: Toolbars and Customization, task, P3)

task

Tracking

()

RESOLVED FIXED
83 Branch
Tracking Status
firefox77 --- wontfix
firefox83 --- fixed

People

(Reporter: Gijs, Assigned: emmamalysz)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxperf:p3])

Attachments

(2 files)

+++ This bug was initially created as a clone of Bug #1634031 +++

This is

<panel id="pageActionPanel>

This is going to be a little tricky, but manageable.

I think steps that should roughly work are:

  1. migrate to fluent for the labeling of actions. We probably need to accept that there will be "duplicate" labels for the tooltips used for actions in the address bar, and visible labels for the menuitems. This should get rid of the awkard inheritance of titles in takeActionTitleFromPanel from markup on the panel node itself.
  2. update all supported actions that respond to other events (e.g. navigation) to check if the panel is present, without de-lazifying it, and otherwise only update in-addressbar nodes when this happens (if any).
  3. change code in browser-pageActions.js to handle the panel not being present, and only actually create it if it is being shown.
  4. doublecheck how this all works with extension-provided page actions...

Marking fxperf:p3 because I think it makes sense to start with the more straightforward cases.

Whiteboard: [fxperf] → [fxperf:p3]
Severity: -- → N/A
Assignee: nobody → emalysz
Attachment #9171311 - Attachment description: Bug 1634042, place page action in a template and add strings to fluent. → Bug 1634042, Part 1: migrate page action titles to fluent.
Pushed by rmaries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b0c42fffcbc6
Part 1: migrate page action titles to fluent. r=Gijs,fluent-reviewers,flod
Keywords: leave-open
Pushed by rmaries@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0798aa08c2cb
Part 2: lazify page action panel r=Gijs
Flags: needinfo?(emalysz)
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d4c1abcfbba0
Part 2: lazify page action panel r=Gijs
Pushed by emalysz@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b95ecac8758c
Part 2: lazify page action panel r=Gijs
Keywords: leave-open
Flags: needinfo?(emalysz)
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED

🎉

Target Milestone: --- → 83 Branch

Hey Emma, I'm seeing test failures in browser_UsageTelemetry_interaction.js and browser_UsageTelemetry_toolbars.js where the test tries to get access to #pageActionPanel but fails as the node is not created yet. I've replaced these locally with calls to BrowserPageActions.panelNode which forces the initialization. Are you aware of these failures? Should I include them in a separate commit for my work (it is unrelated and focused on the bookmarks toolbar)?

Flags: needinfo?(emalysz)
Regressions: 1670269

Thanks for pointing that out! Covering the test fixes in bug 1670269.

Flags: needinfo?(emalysz)
You need to log in before you can comment on or make changes to this bug.