Remove about:welcome trailhead, full page and ReturnToAMO templates
Categories
(Firefox :: Messaging System, enhancement, P1)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox82 | --- | verified |
People
(Reporter: pdahiya, Assigned: pdahiya)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
Opening bug to refactor and remove trailhead about:welcome experience.
- Ensure extended triplets functionality is hidden and can be enabled by pref flip
- Enterprise builds should be able to turn off firstrun and extended triplets with pref flip
|
||
Updated•4 years ago
|
|
||
Comment 1•4 years ago
|
||
Let's also remove the custom experiment enrollment ping for Trailhead.
|
|
||
Updated•4 years ago
|
|
Assignee | |
Comment 2•4 years ago
|
||
|
|
Assignee | |
Comment 3•4 years ago
|
||
NI @mkaply to help file bugs to update enterprise policies that rely on trailhead.firstrun.branches pref to override firstrun flow. With this fix in 82, We should turn off first run on-boarding using pref browser.aboutwelcome.enabled. Thanks!
|
||
Comment 4•4 years ago
|
||
I think you could probably do this as part of this patch. Just remove the following lines in Policies.jsm:
https://searchfox.org/mozilla-central/rev/2b250967a66886398e5e798371484fd018d88a22/browser/components/enterprisepolicies/Policies.jsm#570
https://searchfox.org/mozilla-central/rev/2b250967a66886398e5e798371484fd018d88a22/browser/components/enterprisepolicies/Policies.jsm#1318
https://searchfox.org/mozilla-central/rev/2b250967a66886398e5e798371484fd018d88a22/browser/components/enterprisepolicies/Policies.jsm#1986
|
||
Updated•4 years ago
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
Assignee | |
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
|
|
||
Updated•4 years ago
|
Pushed by pdahiya@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/08f94ba4c50c Remove about:welcome trailhead, full page and ReturnToAMO templates r=perftest-reviewers,Mardak,mkaply,nanj,sparky
|
||
Comment 6•4 years ago
|
||
Backed out for browser chrome failures on browser_all_files_referenced.js.
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=315407184&repo=autoland&lineNumber=3175
Backout link: https://hg.mozilla.org/integration/autoland/rev/6d91f5b4cc322020443d2789407a3fe0ad50091b
|
|
Assignee | |
Comment 7•4 years ago
|
||
Fixed test by removing unreferenced file browser/components/newtab/data/content/assets/gift-extension.svg
Pushed by pdahiya@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/47f3048656d3 Remove about:welcome trailhead, full page and ReturnToAMO templates r=perftest-reviewers,Mardak,mkaply,nanj,sparky
|
||
Comment 9•4 years ago
|
||
| bugherder | ||
|
||
Comment 10•4 years ago
|
||
I have verified the following using Firefox 82 RC en-US (Build ID: 20201014125134) on Windows 10 x64, macOS 10.15.6, and Ubuntu Linux 20.04 x64:
- The "about:newtab" page without trailhead modal is correctly displayed when navigating to the "about:welcome" page while the "browser.aboutwelcome.enabled" pref is set to "false".
- The "about:newtab" page with the "Dynamic Triplets" is correctly displayed when navigating to the "about:welcome" page while the "browser.aboutwelcome.enabled" pref is set to "false", and the "trailhead.firstrun.newtab.triplets" pref is set to "dynamic".
Description
•