Closed Bug 1708193 Opened 3 years ago Closed 3 years ago

Remove mozapps/extensions/internal/Content.js

Categories

(Toolkit :: Add-ons Manager, task, P2)

Product:
Toolkit
Component:
Add-ons Manager
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
96 Branch
Tracking Flags:
Tracking Status
firefox96 --- fixed

People

(Reporter: zombie, Assigned: zombie)

References

(Blocks 1 open bug)

Details

(Whiteboard: [addons-jira])

Attachments

(1 file)

Bug 1708193 - Remove mozapps/extensions/internal/Content.js r?rpl
48 bytes, text/x-phabricator-request
Details | Review

We shouldn't be loading it eagerly in every tab, and second message/notification is already obsolete.
https://searchfox.org/mozilla-central/source/toolkit/mozapps/extensions/internal/Content.js

Probably move it to something like ExtensionContent, though ProcessActors don't support broadcast messages.
https://searchfox.org/mozilla-central/rev/3aef835f6c/toolkit/components/extensions/ExtensionContent.jsm#1217

Hey Tom, is there any difference between this bugzilla issue and Bug 1708239?
At a first glance it looks that one of them may be marked as a duplicate of the other one, but I didn't want to do it without asking you first.

Besides that, I think that it may be reasonable to move these issue (or the one that stays) into "Toolkit :: Add-ons Manager" (but make sure they still block fission-webext for make it easier to keep track of them across the bugzilla components).

Flags: needinfo?(tomica)

thanks luca

Component: General → Add-ons Manager
Flags: needinfo?(tomica)
Product: WebExtensions → Toolkit
Assignee: nobody → tomica
Severity: -- → N/A
Priority: -- → P2

Use Extension:FlushJarCache listener in ExtensionProcessScript.jsm instead,
it's already loaded everywhere and early enough from AddonManager.jsm.

Whiteboard: [addons-jira]
Whiteboard: [addons-jira]
Whiteboard: [addons-jira]
Attachment #9248472 - Attachment description: Bug 1708193 - Remove mozapps/extensions/internal/Content.js r?willdurand → Bug 1708193 - Remove mozapps/extensions/internal/Content.js r?rpl
Pushed by tjovanovic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7c35d5f8e06f
Remove mozapps/extensions/internal/Content.js r=rpl

https://hg.mozilla.org/mozilla-central/rev/7c35d5f8e06f

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox96: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 96 Branch

== Change summary for alert #32423 (as of Mon, 22 Nov 2021 12:16:19 GMT) ==

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
0.43% Base Content JS macosx1015-64-shippable-qr 1,788,464.00 -> 1,780,704.00
0.42% Base Content JS linux1804-64-shippable-qr 1,787,704.00 -> 1,780,256.00
0.41% Base Content JS windows10-64-2004-shippable-qr 1,793,184.00 -> 1,785,743.33
0.37% Base Content JS linux1804-64-shippable-qr 1,787,032.00 -> 1,780,351.33

For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=32423

You need to log in before you can comment on or make changes to this bug.