Closed Bug 1891599 Opened 3 months ago Closed 3 months ago

Create PiP JWPlayer Wrapper

Categories

(Toolkit :: Picture-in-Picture, defect, P3)

Product:
Toolkit
Component:
Picture-in-Picture
Version:
Firefox 126
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
127 Branch
Tracking Flags:
Tracking Status
firefox127 --- verified
firefox128 --- verified

People

(Reporter: joe.scott.webster, Assigned: joe.scott.webster)

References

Details

Attachments

(2 files, 2 obsolete files)

AOL PiP - JWPlayer.png
532.20 KB, image/png
Details
Bug 1891599 - Create PiP JWPlayer Wrapper r=kpatenio
48 bytes, text/x-phabricator-request
Details | Review
Attached image AOL PiP - JWPlayer.png —

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/123.0.0.0 Safari/537.36

Steps to reproduce:

I can reproduce this bug by following the steps below:

  1. Navigate to https://www.aol.com/o-j-simpson-former-nfl-145545988.html
  2. Play the video
  3. Click Picture-In-Picture toggle
  4. Click Closed Captioning logo and enable English subtitles

Actual results:

PiP "subtitles" icon remains disabled and PiP subtitles do not appear.

Expected results:

PiP "subtitles" icon should be clickable and PiP subtitles should be visible

Note: This bug assumes that Bug 1825105 (https://bugzilla.mozilla.org/show_bug.cgi?id=1825105#c8) is already merged with Firefox Nightly (this patch was landed earlier today 4/15/24).

Thanks for filing this bug! Feel free to assign yourself on Bugzilla and submit a patch tagging #pip-reviewers once it's ready for review.

Changing ticket type to "defect" since, technically speaking, there's unexpected results tied to this behaviour.

Severity: -- → S3
Status: UNCONFIRMED → NEW
Type: enhancement → defect
Depends on: 1825105
Ever confirmed: true
Priority: -- → P3
Assignee: nobody → joe.scott.webster
Summary: Create AOL site-specific wrapper that enables PiP captions for JWPlayer (in addition to videoJS). → Create PiP JWPlayer Wrapper r=kpatenio
Attachment #9397225 - Attachment description: Bug 1891599 - Create AOL site-specific wrapper. r=kpatenio → Bug 1891599 - Create PiP JWPlayer Wrapper r=kpatenio
Attachment #9397586 - Attachment is obsolete: true
Attachment #9398003 - Attachment is obsolete: true
Summary: Create PiP JWPlayer Wrapper r=kpatenio → Create PiP JWPlayer Wrapper
Pushed by scunnane@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cc6fe766b0cb
Create PiP JWPlayer Wrapper r=niklas
Blocks: 1893061

https://hg.mozilla.org/mozilla-central/rev/cc6fe766b0cb

Status: NEW → RESOLVED
Closed: 3 months ago
status-firefox127: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 127 Branch
Flags: qe-verify+

Reproducible on a 2024-04-15 Nightly build on Windows 10.
Verified as fixed on Firefox Nightly 128.0a1 and Firefox 127.0b2 on Windows 10, macOS 12, Ubuntu 22.

Status: RESOLVED → VERIFIED
status-firefox127: fixed → verified
status-firefox128: --- → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.