Skip to content

Commit

Permalink
Make layout overflow calculations account for align-content/justify-c…
Browse files Browse the repository at this point in the history 
…ontent.

https://bugs.webkit.org/show_bug.cgi?id=267849
rdar://121366949
Reviewed by Simon Fraser.

1. Updates logic in RenderBlockFlow, RenderGrid, and RenderFlexibleBox
   to account for align-content/justify-content as appropriate by:
   a) Changing allowed overflow calculations to return allowances rather than
       sides of the box so that allowable overflow can be accounted for when
       centering or end-aligning content.
   b) Updating isEndward() and isStartward() to fully incorporate flex-specific
       left/right logic to make this easier.
2. Fixes an obvious error in isEndward() center handling (now that we need it).
3. Fixes broken overflow calculation in RTL + vertical writing modes.
4. Fixes broken alignment calculation in flexbox in RTL + vertical writing modes.
5. Applies alignContentShift to oldClientAfterEdge to correct block overflow calculation.

Caveat: RenderFlexibleBox doesn't store allowances, so this fix isn't 100%
correct for certain types of overflow; but it handles the common cases.

* LayoutTests/TestExpectations: Mark image failures due to missing 'safe' implementation in flexbox.
* LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/negative-overflow-002-expected.txt: Rebaseline.
* LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/negative-overflow-expected.txt: Rebaseline.
* LayoutTests/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-content-alignment-overflow-002-expected.txt: Rebaseline.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-001-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-002-ref.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-block-001-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-block-001.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-block-002-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-block-002.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-flex-col-reverse-001-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-flex-col-reverse-001.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-flex-col-reverse-002-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-flex-col-reverse-002.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-flex-col-wrap-001-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-flex-col-wrap-001.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-flex-col-wrap-002-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-flex-col-wrap-002.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-flex-row-reverse-001-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-flex-row-reverse-001.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-flex-row-reverse-002-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-flex-row-reverse-002.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-flex-row-wrap-001-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-flex-row-wrap-001.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-flex-row-wrap-002-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-flex-row-wrap-002.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-grid-001-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-grid-001.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-grid-002-expected.html: Added.
* LayoutTests/imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-grid-002.html: Added.
* LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-flexbox/negative-overflow-002-expected.txt: Removed.
* Source/WebCore/platform/LengthBox.h: Add LayoutOptionalOutsets typedef.
* Source/WebCore/platform/RectEdges.h:
(WebCore::RectEdges::xFlippedCopy): Add method for use in RenderFlexibleBox.
(WebCore::RectEdges::yFlippedCopy): Add method for use in RenderFlexibleBox.
(WebCore::RectEdges::blockFlippedCopy): Add logical version.
(WebCore::RectEdges::inlineFlippedCopy): Add logical version.
* Source/WebCore/rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::layoutBlock): Cache alignment overflow allowance.
(WebCore::RenderBlockFlow::shiftForAlignContent): Allow scroll containers to align.
(WebCore::RenderBlockFlow::allowedLayoutOverflow const): Add new overflow method.
(WebCore::RenderBlockFlow::isTopLayoutOverflowAllowed const): Deleted.
(WebCore::RenderBlockFlow::isLeftLayoutOverflowAllowed const): Deleted.
* Source/WebCore/rendering/RenderBlockFlow.h: Switch to new layout overflow API.
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::allowedLayoutOverflow const): Implement new layout overflow API.
(WebCore::RenderBox::addLayoutOverflow): Hook into new layout overflow API.
* Source/WebCore/rendering/RenderBox.h: Switch to new layout overflow API.
* Source/WebCore/rendering/RenderBoxInlines.h: Remove old API.
(WebCore::RenderBox::intrinsicLogicalHeight const):
(WebCore::RenderBox::isLeftLayoutOverflowAllowed const): Deleted.
(WebCore::RenderBox::isTopLayoutOverflowAllowed const): Deleted.
* Source/WebCore/rendering/RenderFlexibleBox.cpp:
(WebCore::initialJustifyContentOffset): Fix broken left/right alignment calculation.
(WebCore::leftRightAxisDirectionFromStyle): Add helper method.
(WebCore::RenderFlexibleBox::allowedLayoutOverflow const): Implement new layout overflow API.
(WebCore::RenderFlexibleBox::isTopLayoutOverflowAllowed const): Deleted.
(WebCore::RenderFlexibleBox::isLeftLayoutOverflowAllowed const): Deleted.
* Source/WebCore/rendering/RenderFlexibleBox.h: Switch to new layout overflow API.
* Source/WebCore/rendering/RenderGrid.cpp:
(WebCore::RenderGrid::allowedLayoutOverflow const): Implement new layout overflow API.
* Source/WebCore/rendering/RenderGrid.h: Switch to new layout overflow API.
* Source/WebCore/rendering/style/StyleContentAlignmentData.cpp:
(WebCore::StyleContentAlignmentData::iStartward const): Incorporate Flexbox left/right logic.
(WebCore::StyleContentAlignmentData::isEndward const): Make centering return false. Incorporate Flexbox left/right logic.
* Source/WebCore/rendering/style/StyleContentAlignmentData.h: Update to pass optional TextDirection.

Canonical link: https://commits.webkit.org/273737@main
  • Loading branch information
@fantasai
fantasai authored and Ahmad Saleem committed Jan 30, 2024
1 parent ea8fdd5 commit 3000bc1
Show file tree
Hide file tree
Showing 44 changed files with 12,033 additions and 541 deletions.
4 changes: 4 additions & 0 deletions LayoutTests/TestExpectations
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4871,6 +4871,10 @@ webkit.org/b/214458 imported/w3c/web-platform-tests/css/css-multicol/multicol-fi
webkit.org/b/214458 imported/w3c/web-platform-tests/css/css-multicol/multicol-list-item-002.html [ ImageOnlyFailure ]
webkit.org/b/214458 imported/w3c/web-platform-tests/css/css-multicol/nested-with-too-tall-line.html [ ImageOnlyFailure ]

webkit.org/b/263893 imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-flex-col-reverse-001.html [ ImageOnlyFailure ]
webkit.org/b/263893 imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-flex-col-wrap-001.html [ ImageOnlyFailure ]
webkit.org/b/263893 imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-flex-row-reverse-001.html [ ImageOnlyFailure ]
webkit.org/b/263893 imported/w3c/web-platform-tests/css/css-overflow/overflow-alignment-flex-row-wrap-001.html [ ImageOnlyFailure ]
webkit.org/b/214459 imported/w3c/web-platform-tests/css/css-overflow/text-overflow-ellipsis-editing-input.html [ ImageOnlyFailure ]
webkit.org/b/214459 imported/w3c/web-platform-tests/css/css-overflow/text-overflow-ellipsis-vertical-001.html [ ImageOnlyFailure ]
webkit.org/b/214459 imported/w3c/web-platform-tests/css/css-overflow/text-overflow-ellipsis-vertical-rtl-001.html [ ImageOnlyFailure ]
Expand Down
58 changes: 24 additions & 34 deletions ...tTests/imported/w3c/web-platform-tests/css/css-flexbox/negative-overflow-002-expected.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ PASS .container 1
PASS .container 2
FAIL .container 3 assert_equals:
<div class="container" data-expected-scroll-width="130" data-expected-scroll-height="370" style="writing-mode: horizontal-tb; direction: ltr; flex-flow: wrap-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollHeight expected 370 but got 105
scrollHeight expected 370 but got 360
FAIL .container 4 assert_equals:
<div class="container" data-expected-scroll-width="370" data-expected-scroll-height="130" style="writing-mode: horizontal-tb; direction: ltr; flex-flow: row-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollWidth expected 370 but got 360
Expand All @@ -233,7 +233,7 @@ PASS .container 7
PASS .container 8
FAIL .container 9 assert_equals:
<div class="container" data-expected-scroll-width="370" data-expected-scroll-height="130" style="writing-mode: horizontal-tb; direction: ltr; flex-flow: column wrap-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollWidth expected 370 but got 105
scrollWidth expected 370 but got 360
FAIL .container 10 assert_equals:
<div class="container" data-expected-scroll-width="130" data-expected-scroll-height="370" style="writing-mode: horizontal-tb; direction: ltr; flex-flow: column-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollHeight expected 370 but got 360
Expand All @@ -242,7 +242,7 @@ FAIL .container 11 assert_equals:
scrollHeight expected 130 but got 120
FAIL .container 12 assert_equals:
<div class="container" data-expected-scroll-width="370" data-expected-scroll-height="130" style="writing-mode: horizontal-tb; direction: ltr; flex-flow: column-reverse wrap-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollWidth expected 370 but got 105
scrollWidth expected 370 but got 360
FAIL .container 13 assert_equals:
<div class="container" data-expected-scroll-width="370" data-expected-scroll-height="130" style="writing-mode: horizontal-tb; direction: rtl; flex-flow: row;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollWidth expected 370 but got 360
Expand All @@ -252,24 +252,18 @@ scrollWidth expected 130 but got 120
FAIL .container 15 assert_equals:
<div class="container" data-expected-scroll-width="130" data-expected-scroll-height="370" style="writing-mode: horizontal-tb; direction: rtl; flex-flow: wrap-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollWidth expected 130 but got 120
FAIL .container 16 assert_equals:
<div class="container" data-expected-scroll-width="370" data-expected-scroll-height="130" style="writing-mode: horizontal-tb; direction: rtl; flex-flow: row-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollWidth expected 370 but got 105
FAIL .container 17 assert_equals:
<div class="container" data-expected-scroll-width="130" data-expected-scroll-height="370" style="writing-mode: horizontal-tb; direction: rtl; flex-flow: row-reverse wrap;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollWidth expected 130 but got 105
PASS .container 16
PASS .container 17
FAIL .container 18 assert_equals:
<div class="container" data-expected-scroll-width="130" data-expected-scroll-height="370" style="writing-mode: horizontal-tb; direction: rtl; flex-flow: row-reverse wrap-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollWidth expected 130 but got 105
scrollHeight expected 370 but got 360
FAIL .container 19 assert_equals:
<div class="container" data-expected-scroll-width="130" data-expected-scroll-height="370" style="writing-mode: horizontal-tb; direction: rtl; flex-flow: column;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollWidth expected 130 but got 120
FAIL .container 20 assert_equals:
<div class="container" data-expected-scroll-width="370" data-expected-scroll-height="130" style="writing-mode: horizontal-tb; direction: rtl; flex-flow: column wrap;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollWidth expected 370 but got 360
FAIL .container 21 assert_equals:
<div class="container" data-expected-scroll-width="370" data-expected-scroll-height="130" style="writing-mode: horizontal-tb; direction: rtl; flex-flow: column wrap-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollWidth expected 370 but got 105
PASS .container 21
FAIL .container 22 assert_equals:
<div class="container" data-expected-scroll-width="130" data-expected-scroll-height="370" style="writing-mode: horizontal-tb; direction: rtl; flex-flow: column-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollWidth expected 130 but got 120
Expand All @@ -278,12 +272,12 @@ FAIL .container 23 assert_equals:
scrollWidth expected 370 but got 360
FAIL .container 24 assert_equals:
<div class="container" data-expected-scroll-width="370" data-expected-scroll-height="130" style="writing-mode: horizontal-tb; direction: rtl; flex-flow: column-reverse wrap-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollWidth expected 370 but got 105
scrollHeight expected 130 but got 120
PASS .container 25
PASS .container 26
FAIL .container 27 assert_equals:
<div class="container" data-expected-scroll-width="370" data-expected-scroll-height="130" style="writing-mode: vertical-rl; direction: ltr; flex-flow: wrap-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollWidth expected 370 but got 105
scrollWidth expected 370 but got 360
FAIL .container 28 assert_equals:
<div class="container" data-expected-scroll-width="130" data-expected-scroll-height="370" style="writing-mode: vertical-rl; direction: ltr; flex-flow: row-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollHeight expected 370 but got 360
Expand All @@ -292,12 +286,12 @@ FAIL .container 29 assert_equals:
scrollHeight expected 130 but got 120
FAIL .container 30 assert_equals:
<div class="container" data-expected-scroll-width="370" data-expected-scroll-height="130" style="writing-mode: vertical-rl; direction: ltr; flex-flow: row-reverse wrap-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollWidth expected 370 but got 105
scrollWidth expected 370 but got 360
PASS .container 31
PASS .container 32
FAIL .container 33 assert_equals:
<div class="container" data-expected-scroll-width="130" data-expected-scroll-height="370" style="writing-mode: vertical-rl; direction: ltr; flex-flow: column wrap-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollHeight expected 370 but got 115
scrollHeight expected 370 but got 360
FAIL .container 34 assert_equals:
<div class="container" data-expected-scroll-width="370" data-expected-scroll-height="130" style="writing-mode: vertical-rl; direction: ltr; flex-flow: column-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollWidth expected 370 but got 360
Expand All @@ -315,25 +309,23 @@ FAIL .container 38 assert_equals:
scrollHeight expected 130 but got 105
FAIL .container 39 assert_equals:
<div class="container" data-expected-scroll-width="370" data-expected-scroll-height="130" style="writing-mode: vertical-rl; direction: rtl; flex-flow: wrap-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollWidth expected 370 but got 105
scrollWidth expected 370 but got 360
FAIL .container 40 assert_equals:
<div class="container" data-expected-scroll-width="130" data-expected-scroll-height="370" style="writing-mode: vertical-rl; direction: rtl; flex-flow: row-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollHeight expected 370 but got 105
scrollHeight expected 370 but got 385
FAIL .container 41 assert_equals:
<div class="container" data-expected-scroll-width="370" data-expected-scroll-height="130" style="writing-mode: vertical-rl; direction: rtl; flex-flow: row-reverse wrap;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollHeight expected 130 but got 105
scrollHeight expected 130 but got 145
FAIL .container 42 assert_equals:
<div class="container" data-expected-scroll-width="370" data-expected-scroll-height="130" style="writing-mode: vertical-rl; direction: rtl; flex-flow: row-reverse wrap-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollWidth expected 370 but got 105
scrollWidth expected 370 but got 360
FAIL .container 43 assert_equals:
<div class="container" data-expected-scroll-width="370" data-expected-scroll-height="130" style="writing-mode: vertical-rl; direction: rtl; flex-flow: column;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollHeight expected 130 but got 120
FAIL .container 44 assert_equals:
<div class="container" data-expected-scroll-width="130" data-expected-scroll-height="370" style="writing-mode: vertical-rl; direction: rtl; flex-flow: column wrap;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollHeight expected 370 but got 360
FAIL .container 45 assert_equals:
<div class="container" data-expected-scroll-width="130" data-expected-scroll-height="370" style="writing-mode: vertical-rl; direction: rtl; flex-flow: column wrap-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollHeight expected 370 but got 105
PASS .container 45
FAIL .container 46 assert_equals:
<div class="container" data-expected-scroll-width="370" data-expected-scroll-height="130" style="writing-mode: vertical-rl; direction: rtl; flex-flow: column-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollWidth expected 370 but got 360
Expand All @@ -347,7 +339,7 @@ PASS .container 49
PASS .container 50
FAIL .container 51 assert_equals:
<div class="container" data-expected-scroll-width="370" data-expected-scroll-height="130" style="writing-mode: vertical-lr; direction: ltr; flex-flow: wrap-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollWidth expected 370 but got 105
scrollWidth expected 370 but got 360
FAIL .container 52 assert_equals:
<div class="container" data-expected-scroll-width="130" data-expected-scroll-height="370" style="writing-mode: vertical-lr; direction: ltr; flex-flow: row-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollHeight expected 370 but got 360
Expand All @@ -356,12 +348,12 @@ FAIL .container 53 assert_equals:
scrollHeight expected 130 but got 120
FAIL .container 54 assert_equals:
<div class="container" data-expected-scroll-width="370" data-expected-scroll-height="130" style="writing-mode: vertical-lr; direction: ltr; flex-flow: row-reverse wrap-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollWidth expected 370 but got 105
scrollWidth expected 370 but got 360
PASS .container 55
PASS .container 56
FAIL .container 57 assert_equals:
<div class="container" data-expected-scroll-width="130" data-expected-scroll-height="370" style="writing-mode: vertical-lr; direction: ltr; flex-flow: column wrap-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollHeight expected 370 but got 115
scrollHeight expected 370 but got 360
FAIL .container 58 assert_equals:
<div class="container" data-expected-scroll-width="370" data-expected-scroll-height="130" style="writing-mode: vertical-lr; direction: ltr; flex-flow: column-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollWidth expected 370 but got 360
Expand All @@ -379,25 +371,23 @@ FAIL .container 62 assert_equals:
scrollHeight expected 130 but got 105
FAIL .container 63 assert_equals:
<div class="container" data-expected-scroll-width="370" data-expected-scroll-height="130" style="writing-mode: vertical-lr; direction: rtl; flex-flow: wrap-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollWidth expected 370 but got 105
scrollWidth expected 370 but got 360
FAIL .container 64 assert_equals:
<div class="container" data-expected-scroll-width="130" data-expected-scroll-height="370" style="writing-mode: vertical-lr; direction: rtl; flex-flow: row-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollHeight expected 370 but got 105
scrollHeight expected 370 but got 385
FAIL .container 65 assert_equals:
<div class="container" data-expected-scroll-width="370" data-expected-scroll-height="130" style="writing-mode: vertical-lr; direction: rtl; flex-flow: row-reverse wrap;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollHeight expected 130 but got 105
scrollHeight expected 130 but got 145
FAIL .container 66 assert_equals:
<div class="container" data-expected-scroll-width="370" data-expected-scroll-height="130" style="writing-mode: vertical-lr; direction: rtl; flex-flow: row-reverse wrap-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollWidth expected 370 but got 105
scrollWidth expected 370 but got 360
FAIL .container 67 assert_equals:
<div class="container" data-expected-scroll-width="370" data-expected-scroll-height="130" style="writing-mode: vertical-lr; direction: rtl; flex-flow: column;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollHeight expected 130 but got 120
FAIL .container 68 assert_equals:
<div class="container" data-expected-scroll-width="130" data-expected-scroll-height="370" style="writing-mode: vertical-lr; direction: rtl; flex-flow: column wrap;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollHeight expected 370 but got 360
FAIL .container 69 assert_equals:
<div class="container" data-expected-scroll-width="130" data-expected-scroll-height="370" style="writing-mode: vertical-lr; direction: rtl; flex-flow: column wrap-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollHeight expected 370 but got 105
PASS .container 69
FAIL .container 70 assert_equals:
<div class="container" data-expected-scroll-width="370" data-expected-scroll-height="130" style="writing-mode: vertical-lr; direction: rtl; flex-flow: column-reverse;"><div class="item">1</div><div class="item">2</div><div class="item">3</div></div>
scrollWidth expected 370 but got 360
Expand Down
9 changes: 2 additions & 7 deletions LayoutTests/imported/w3c/web-platform-tests/css/css-flexbox/negative-overflow-expected.txt
View file
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,7 @@ PASS .flexbox 1
PASS .flexbox 2
PASS .flexbox 3
PASS .flexbox 4
FAIL .flexbox 5 assert_equals:
<div class="flexbox wrap-reverse" data-expected-scroll-height="200">
<div></div>
<div></div>
</div>
scrollHeight expected 200 but got 50
PASS .flexbox 5
PASS .flexbox 6
PASS .flexbox 7
PASS .flexbox 8
Expand All @@ -19,5 +14,5 @@ FAIL .flexbox 11 assert_equals:
<div></div>
<div></div>
</div>
scrollHeight expected 215 but got 65
scrollHeight expected 215 but got 210

Loading

0 comments on commit 3000bc1

Please sign in to comment.