Last Call Review of draft-ietf-cbor-edn-literals-09
review-ietf-cbor-edn-literals-09-genart-lc-halpern-2024-05-25-00

Request Review of draft-ietf-cbor-edn-literals
Requested revision No specific revision (document currently at 10)
Type Last Call Review
Team General Area Review Team (Gen-ART) (genart)
Deadline 2024-06-05
Requested 2024-05-22
Authors Carsten Bormann
I-D last updated 2024-05-25
Completed reviews Opsdir Last Call review of -09 by Linda Dunbar (diff)
Genart Last Call review of -09 by Joel M. Halpern (diff)
Secdir Last Call review of -09 by Rifaat Shekh-Yusef (diff)
Assignment Reviewer Joel M. Halpern
State Completed
Request Last Call review on draft-ietf-cbor-edn-literals by General Area Review Team (Gen-ART) Assigned
Posted at https://mailarchive.ietf.org/arch/msg/gen-art/91u4e2ydRvQf-B4UeKra2Lb6jn8
Reviewed revision 09 (document currently at 10)
Result Ready w/nits
Completed 2024-05-25
review-ietf-cbor-edn-literals-09-genart-lc-halpern-2024-05-25-00
I am the assigned Gen-ART reviewer for this draft. The General Area
Review Team (Gen-ART) reviews all IETF documents being processed
by the IESG for the IETF Chair.  Please treat these comments just
like any other last call comments.

For more information, please see the FAQ at

<https://wiki.ietf.org/en/group/gen/GenArtFAQ>.

Document: draft-ietf-cbor-edn-literals-09
Reviewer: Joel Halpern
Review Date: 2024-05-25
IETF LC End Date: 2024-06-05
IESG Telechat date: Not scheduled for a telechat

Summary: This draft is ready for publication as an Informational RFC.
   There is one NIT noted below.

Major issues: N/A

Minor issues: N/A

Nits/editorial comments:
    It would be helpful if section 4.2 (IANA Considerations creating the
    Encoding Indications registry) said it was recording the assignments made
    in RFC 8949 section 8.1, and adding the _i indication.  It would also be
    helpful if that sentence noted that _i is defined in the ABNF appendix, as
    otherwise the reader is left going "what is this and where did it come
    from?"