This repository has been archived by the owner on May 9, 2024. It is now read-only.
Fix issue where 10updocker fails to add custom domain entries in /etc/hosts.
#338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix error when adding host file entries
```
Error: Command failed: /Users/admin/Library/Caches/fnm_multishells/2098_1687516908456/bin/node /Users/admin/Library/Application Support/fnm/node-versions/v18.16.0/installation/lib/node_modules/wp-local-docker/hosts.js add gus.local
node:internal/modules/cjs/loader:1078
throw err;
^
Error: Cannot find module '/Users/admin/Library/Application'
at Module._resolveFilename (node:internal/modules/cjs/loader:1075:15)
at Module._load (node:internal/modules/cjs/loader:920:27)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
at node:internal/main/run_main_module:23:47 {
code: 'MODULE_NOT_FOUND',
requireStack: []
}
Node.js v18.16.0
at /Users/admin/Library/Application Support/fnm/node-versions/v18.16.0/installation/lib/node_modules/wp-local-docker/node_modules/sudo-prompt/index.js:390:27
at FSReqCallback.readFileAfterClose [as oncomplete] (node:internal/fs/read_file_context:68:3) {
code: 1
}
⚠ Something went wrong adding host file entries. You may need to add the /etc/hosts entries manually.
```
Fix error when removing host file entries
```
Error: Command failed: /Users/admin/Library/Caches/fnm_multishells/2098_1687516908456/bin/node /Users/admin/Library/Application Support/fnm/node-versions/v18.16.0/installation/lib/node_modules/wp-local-docker/hosts.js remove gus.local
node:internal/modules/cjs/loader:1078
throw err;
^
Error: Cannot find module '/Users/admin/Library/Application'
at Module._resolveFilename (node:internal/modules/cjs/loader:1075:15)
at Module._load (node:internal/modules/cjs/loader:920:27)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
at node:internal/main/run_main_module:23:47 {
code: 'MODULE_NOT_FOUND',
requireStack: []
}
Node.js v18.16.0
at /Users/admin/Library/Application Support/fnm/node-versions/v18.16.0/installation/lib/node_modules/wp-local-docker/node_modules/sudo-prompt/index.js:390:27
at FSReqCallback.readFileAfterClose [as oncomplete] (node:internal/fs/read_file_context:68:3) {
code: 1
}
⚠ Something went wrong deleting host file entries. There may still be remnants in /etc/hosts
```
darylldoyle
approved these changes
Jul 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Seems like the code assumes that the file path for
mkcertPrebuiltis a valid file system path. It's not always the case.Sometimes (as is the case in #312) the Node is installed in a directory where there's a space in the directory name. Such paths with a space in-between will break the script, if not escaped properly.
As it's rightly pointed out #312 (comment).
I've escaped the shell binary path with double quotes so that unexpected space characters in the file path doesn't break the script.
Closes #312
How to test the Change
Not sure. Haven't followed any testing strategy here. But happy to follow any guidance here.
Changelog Entry
Credits
Props ...
Checklist: