Merge pull request #560 from AR-js-org/issue500

Allow real GPS position to be used, even after fake GPS has been set
AR-js-org · Aug 28, 2023 · 0259764 · 0259764
2 parents 8609ac9 + b069f2a
commit 0259764
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/aframe/build/aframe-ar-new-location-only.js b/aframe/build/aframe-ar-new-location-only.js
diff --git a/aframe/build/aframe-ar-nft.js b/aframe/build/aframe-ar-nft.js
diff --git a/aframe/build/aframe-ar.js b/aframe/build/aframe-ar.js
diff --git a/aframe/src/new-location-based/gps-new-camera.js b/aframe/src/new-location-based/gps-new-camera.js
@@ -36,6 +36,8 @@ AFRAME.registerComponent("gps-new-camera", {
   init: function () {
     this._testForOrientationControls();
 
+    this.fakeGpsStarted = false;
+
     this.threeLoc = new THREEx.LocationBased(
       this.el.sceneEl.object3D,
       this.el.object3D,
@@ -96,6 +98,7 @@ AFRAME.registerComponent("gps-new-camera", {
       maximumAge: this.data.gpsTimeInterval,
     });
     if (
+      !this.fakeGpsStarted &&
       (this.data.simulateLatitude !== 0 || this.data.simulateLongitude !== 0) &&
       (this.data.simulateLatitude != oldData.simulateLatitude ||
         this.data.simulateLongitude != oldData.simulateLongitude)
@@ -105,8 +108,7 @@ AFRAME.registerComponent("gps-new-camera", {
         this.data.simulateLongitude,
         this.data.simulateLatitude
       );
-      this.data.simulateLatitude = 0;
-      this.data.simulateLongitude = 0;
+      this.fakeGpsStarted = true;
     }
     if (this.data.simulateAltitude > -Number.MAX_VALUE) {
       this.threeLoc.setElevation(this.data.simulateAltitude + 1.6);